From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QzOO9-0004BH-H5
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 03:42:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QzOO7-0001qr-VT
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 03:42:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QzOO7-0001qm-OO
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 03:42:07 -0400
Message-ID: <4E6088CA.4030005@redhat.com>
Date: Fri, 02 Sep 2011 09:42:02 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1314891739-1881-1-git-send-email-kraxel@redhat.com>
	<1314891739-1881-2-git-send-email-kraxel@redhat.com>
	<4E5FDEE0.2010908@codemonkey.ws>
In-Reply-To: <4E5FDEE0.2010908@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] Probe for libcheck by default.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 09/01/11 21:37, Anthony Liguori wrote:
> On 09/01/2011 10:42 AM, Gerd Hoffmann wrote:
>> Probe for libcheck and build checks (if found) by default.
>> Can be explicitly disabled using --disable-check-utests.
>>
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>> ---
>> configure | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I think we should convert the check tests to gtest, and then have make
> check use gtester and gtester-report generate a single report of all of
> the test cases.

I wouldn't object, that is *way* beyond the scope of this little patch 
series though.

> We could then have build bot run make check and post the output.

Running "make check" in buildbot is indeed the motivation to do this ;)

> I don't
> want to end up with a bunch of non gtest unit tests...

This patch series doesn't add any.  It just adds some build system glue 
so "make check" runs the existing stuff.

cheers,
   Gerd