From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzSgm-00036H-5u for qemu-devel@nongnu.org; Fri, 02 Sep 2011 08:17:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzSgl-0005sz-5U for qemu-devel@nongnu.org; Fri, 02 Sep 2011 08:17:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzSgk-0005sk-MX for qemu-devel@nongnu.org; Fri, 02 Sep 2011 08:17:39 -0400 Message-ID: <4E60CA0D.8030205@redhat.com> Date: Fri, 02 Sep 2011 14:20:29 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1312376904-16115-1-git-send-email-armbru@redhat.com> <1312376904-16115-27-git-send-email-armbru@redhat.com> In-Reply-To: <1312376904-16115-27-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: quintela@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, Paolo Bonzini , hch@lst.de Am 03.08.2011 15:08, schrieb Markus Armbruster: > Use a subsection, so that migration to older version still works, > provided the tray is closed and unlocked. > > Signed-off-by: Markus Armbruster Ah, here is the migration part. The state wasn't migrated before, so not doing it in patch 10 doesn't break anything. I would still prefer to add migration in the same patch that adds the fields. You could just move the subsection itself and keep the post_load part here if it doesn't fit naturally in one of the other patches of the series. On another note, have our subsections been fixed meanwhile? If not, increasing the version number instead might be the right choice. Paolo? Kevin