From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzSyE-0008P7-TM for qemu-devel@nongnu.org; Fri, 02 Sep 2011 08:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzSyE-0000nm-1r for qemu-devel@nongnu.org; Fri, 02 Sep 2011 08:35:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzSyD-0000ni-RA for qemu-devel@nongnu.org; Fri, 02 Sep 2011 08:35:42 -0400 Message-ID: <4E60CD90.1060303@redhat.com> Date: Fri, 02 Sep 2011 14:35:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1312376904-16115-1-git-send-email-armbru@redhat.com> <1312376904-16115-27-git-send-email-armbru@redhat.com> <4E60CA0D.8030205@redhat.com> In-Reply-To: <4E60CA0D.8030205@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 26/45] ide/atapi: Preserve tray state on migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: quintela@redhat.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com, Markus Armbruster , lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de On 09/02/2011 02:20 PM, Kevin Wolf wrote: > Ah, here is the migration part. The state wasn't migrated before, so not > doing it in patch 10 doesn't break anything. I would still prefer to add > migration in the same patch that adds the fields. > > You could just move the subsection itself and keep the post_load part > here if it doesn't fit naturally in one of the other patches of the series. > > On another note, have our subsections been fixed meanwhile? If not, > increasing the version number instead might be the right choice. Paolo? No, they haven't, but there's hope they will before 1.0. Paolo