From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTNg-00076P-Dr for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:02:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzTNf-0005uL-CV for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:02:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTNf-0005uF-5Z for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:01:59 -0400 Message-ID: <4E60D453.30004@redhat.com> Date: Fri, 02 Sep 2011 15:04:19 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1312376904-16115-1-git-send-email-armbru@redhat.com> <1312376904-16115-38-git-send-email-armbru@redhat.com> In-Reply-To: <1312376904-16115-38-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest ejected the medium in info block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: quintela@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de Am 03.08.2011 15:08, schrieb Markus Armbruster: > Need to ask the device, so this requires new BlockDevOps member > is_medium_ejected(). > > Signed-off-by: Markus Armbruster I find the name confusing. "medium is ejected" seems to mean "tray is open". It isn't obvious that "tray is closed, but no medium is inserted" is not "medium is ejected". Why not call it tray_open like in the devices? Kevin