From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTWx-0001YQ-Ak for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzTWw-0007zT-7s for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:11:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTWw-0007zG-0j for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:11:34 -0400 Message-ID: <4E60D692.40105@redhat.com> Date: Fri, 02 Sep 2011 15:13:54 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1312376904-16115-1-git-send-email-armbru@redhat.com> <1312376904-16115-42-git-send-email-armbru@redhat.com> In-Reply-To: <1312376904-16115-42-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 41/45] block: New bdrv_set_buffer_alignment() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: quintela@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de Am 03.08.2011 15:08, schrieb Markus Armbruster: > Device models should be able to set it without an unclean include of > block_int.h. > > Signed-off-by: Markus Armbruster > --- > block.c | 6 ++++-- > block.h | 1 + > hw/ide/core.c | 2 +- > hw/scsi-disk.c | 2 +- > hw/virtio-blk.c | 3 +-- > 5 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/block.c b/block.c > index fed0c16..67d9429 100644 > --- a/block.c > +++ b/block.c > @@ -453,7 +453,6 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, > bs->encrypted = 0; > bs->valid_key = 0; > bs->open_flags = flags; > - /* buffer_alignment defaulted to 512, drivers can change this value */ > bs->buffer_alignment = 512; This comment is still right. Kevin