From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTfe-0004q6-Kh for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:20:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzTfc-0001Ch-UH for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:20:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37306 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTfc-0001CV-Go for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:20:32 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 6D58A8CC2B for ; Fri, 2 Sep 2011 15:20:31 +0200 (CEST) Message-ID: <4E60D81A.9030007@suse.de> Date: Fri, 02 Sep 2011 15:20:26 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1312441339-22477-1-git-send-email-david@gibson.dropbear.id.au> <4E42A0D3.1000203@suse.de> <20110811003916.GC6342@yookeroo.fritz.box> <7872027B-E2E0-435F-BE12-65C2E269EA93@suse.de> <20110901014510.GH11906@yookeroo.fritz.box> In-Reply-To: <20110901014510.GH11906@yookeroo.fritz.box> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] pseries machine updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 09/01/2011 03:45 AM, David Gibson wrote: > On Wed, Aug 31, 2011 at 11:17:13AM +0200, Alexander Graf wrote: >> On 11.08.2011, at 02:39, David Gibson wrote: >> >>> On Wed, Aug 10, 2011 at 05:16:35PM +0200, Alexander Graf wrote: >>>> On 08/04/2011 09:02 AM, David Gibson wrote: >>>>> Hi Alex, >>>>> >>>>> Here's another batch of assorted updates for the pseries machine. >>>> Looks pretty nice. Please update patch 2/6 with the bug you found >>>> and the whitespace problems. I'll put the others into my tree >>>> already. >>> Here's the updated 2/6 >>> >>> From e5b9ba608d4814a46f256337bbf60b94fdc2c5d9 Mon Sep 17 00:00:00 2001 >>> From: Ben Herrenschmidt >>> Date: Thu, 4 Aug 2011 16:56:41 +1000 >>> Subject: [PATCH] Implement POWER7's CFAR in TCG >>> >>> This patch implements support for the CFAR SPR on POWER7 (Come From >>> Address Register), which snapshots the PC value at the time of a branch or >>> an rfid. The latest powerpc-next kernel also catches it and can show it in >>> xmon or in the signal frames. >>> >>> This works well enough to let recent kernels boot (which otherwise oops >>> on the CFAR access). It hasn't been tested enough to be confident that the >>> CFAR values are actually accurate, but one thing at a time. >>> >>> Signed-off-by: Ben Herrenschmidt >>> Signed-off-by: David Gibson >> agraf@lychee:/home/agraf/release/qemu> git pw am 109480 >> ERROR: code indent should never use tabs >> #107: FILE: target-ppc/translate.c:162: >> +^I^I^I^I offsetof(CPUState, cfar), "cfar");$ >> >> ERROR: code indent should never use tabs >> #174: FILE: target-ppc/translate.c:9289: >> +^Icpu_fprintf(f, " CFAR " TARGET_FMT_lx"\n", env->cfar);$ > Blah. Fixed now, I'll try to get BenH to use the emacs magic to stop > it putting tabs in. > >> WARNING: space prohibited between function name and open parenthesis '(' >> #199: FILE: target-ppc/translate_init.c:134: >> +static void spr_read_cfar (void *opaque, int gprn, int sprn) >> >> WARNING: space prohibited between function name and open parenthesis '(' >> #204: FILE: target-ppc/translate_init.c:139: >> +static void spr_write_cfar (void *opaque, int sprn, int gprn) > Well, these are deliberate, on the grounds that matching the > surrounding functions seemed more important than matching the global > style guidelines. > > Revised patch below > > From b35b94ea867550faf99fc553b661739551c9bb8b Mon Sep 17 00:00:00 2001 > From: Ben Herrenschmidt > Date: Thu, 4 Aug 2011 16:56:41 +1000 > Subject: [PATCH] Implement POWER7's CFAR in TCG > > This patch implements support for the CFAR SPR on POWER7 (Come From > Address Register), which snapshots the PC value at the time of a branch or > an rfid. The latest powerpc-next kernel also catches it and can show it in > xmon or in the signal frames. > > This works well enough to let recent kernels boot (which otherwise oops > on the CFAR access). It hasn't been tested enough to be confident that the > CFAR values are actually accurate, but one thing at a time. > > Signed-off-by: Ben Herrenschmidt > Signed-off-by: David Gibson > --- > target-ppc/cpu.h | 8 ++++++++ > target-ppc/translate.c | 28 ++++++++++++++++++++++++++++ > target-ppc/translate_init.c | 23 ++++++++++++++++++++++- > 3 files changed, 58 insertions(+), 1 deletions(-) Thanks, applied. Please resend patches as full patches though. Patchwork doesn't deal too well with updated inline patches. Alex