From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTdI-0003db-PN for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:18:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzTdH-0000vC-Qq for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:18:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzTdH-0000v2-Jv for qemu-devel@nongnu.org; Fri, 02 Sep 2011 09:18:07 -0400 Message-ID: <4E60D83A.5040800@redhat.com> Date: Fri, 02 Sep 2011 15:20:58 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1312376904-16115-1-git-send-email-armbru@redhat.com> <1312376904-16115-43-git-send-email-armbru@redhat.com> In-Reply-To: <1312376904-16115-43-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 42/45] block: Reset buffer alignment on detach List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: quintela@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de Am 03.08.2011 15:08, schrieb Markus Armbruster: > BlockDriverState member buffer_alignment is initially 512. The device > model may set them, with bdrv_set_buffer_alignment(). If the device > model gets detached (hot unplug), the device's alignment is left > behind. Only okay because device hot unplug automatically destroys > the BlockDriverState. But that's a questionable feature, best not to > rely on it. > > Signed-off-by: Markus Armbruster Hm, I'm not sure about this... Maybe instead of doing it on open and detach, which is a strange combination, the right thing would be to do it on attach? Kevin