From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, "Lluís Vilanova" <vilanova@ac.upc.edu>,
"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] build: sort objects to remove duplicates for link
Date: Fri, 02 Sep 2011 09:56:46 -0500 [thread overview]
Message-ID: <4E60EEAE.9070105@codemonkey.ws> (raw)
In-Reply-To: <CAJSP0QVNa+wCio=W8xKqP1Unfa8y+hVwf+X_xwx2jHYhoUCHmQ@mail.gmail.com>
On 09/02/2011 03:42 AM, Stefan Hajnoczi wrote:
> 2011/9/1 Michael Roth<mdroth@linux.vnet.ibm.com>:
>> On 09/01/2011 01:54 PM, Anthony Liguori wrote:
>>>
>>> On 08/25/2011 03:18 AM, Stefan Hajnoczi wrote:
>>>>
>>>> Avoid duplicate object files during the link. There are legitimate
>>>> cases where a link command-line would include duplicate object files
>>>> because two independent subsystems both depend on common infrastructure.
>>>>
>>>> Use GNU make's $(sort) function to remove duplicate object files from
>>>> the link command-line.
>>>>
>>>> Signed-off-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>>>
>>> Applied. Thanks.
>>>
>>
>> Don't think it'll hurt to have both, but "[PATCH 01/15] build: Fix linkage
>> of QEMU_PROG" from Stefan's tracing pull request has the more elegant fix
>> for this.
>
> Agreed, it doesn't hurt to take this one but the $^ fix is nicer and
> already merged.
>
> Anthony: Do you want to revert this patch? It's not necessary.
If someone wants to send a patch, I can apply it, but I don't see the
motivation to revert.
Regards,
Anthony Liguori
> Stefan
>
>
prev parent reply other threads:[~2011-09-02 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 19:53 [Qemu-devel] [PATCH] [simple] Include qemu-timer-common.o in trace-obj-y Lluís
2011-08-25 8:18 ` [Qemu-devel] [PATCH] build: sort objects to remove duplicates for link Stefan Hajnoczi
2011-09-01 18:54 ` Anthony Liguori
2011-09-01 19:47 ` Lluís Vilanova
2011-09-01 19:52 ` Michael Roth
2011-09-02 8:42 ` Stefan Hajnoczi
2011-09-02 14:56 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E60EEAE.9070105@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).