From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52401)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QzVAp-0007xe-I9
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 10:56:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QzVAn-0001yP-RT
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 10:56:51 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:60849)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QzVAn-0001vo-NP
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 10:56:49 -0400
Received: by ywf9 with SMTP id 9so2483987ywf.4
	for <qemu-devel@nongnu.org>; Fri, 02 Sep 2011 07:56:48 -0700 (PDT)
Message-ID: <4E60EEAE.9070105@codemonkey.ws>
Date: Fri, 02 Sep 2011 09:56:46 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20110824195317.14304.63305.stgit@ginnungagap.bsc.es>	<1314260332-10534-1-git-send-email-stefanha@linux.vnet.ibm.com>	<4E5FD4F9.3030107@codemonkey.ws>	<4E5FE26C.7030002@linux.vnet.ibm.com>
	<CAJSP0QVNa+wCio=W8xKqP1Unfa8y+hVwf+X_xwx2jHYhoUCHmQ@mail.gmail.com>
In-Reply-To: <CAJSP0QVNa+wCio=W8xKqP1Unfa8y+hVwf+X_xwx2jHYhoUCHmQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] build: sort objects to remove duplicates
 for link
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, =?ISO-8859-1?Q?Llu=EDs_Vilanova?= <vilanova@ac.upc.edu>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Michael Roth <mdroth@linux.vnet.ibm.com>

On 09/02/2011 03:42 AM, Stefan Hajnoczi wrote:
> 2011/9/1 Michael Roth<mdroth@linux.vnet.ibm.com>:
>> On 09/01/2011 01:54 PM, Anthony Liguori wrote:
>>>
>>> On 08/25/2011 03:18 AM, Stefan Hajnoczi wrote:
>>>>
>>>> Avoid duplicate object files during the link. There are legitimate
>>>> cases where a link command-line would include duplicate object files
>>>> because two independent subsystems both depend on common infrastructure.
>>>>
>>>> Use GNU make's $(sort) function to remove duplicate object files from
>>>> the link command-line.
>>>>
>>>> Signed-off-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>>>
>>> Applied. Thanks.
>>>
>>
>> Don't think it'll hurt to have both, but "[PATCH 01/15] build: Fix linkage
>> of QEMU_PROG" from Stefan's tracing pull request has the more elegant fix
>> for this.
>
> Agreed, it doesn't hurt to take this one but the $^ fix is nicer and
> already merged.
>
> Anthony: Do you want to revert this patch?  It's not necessary.

If someone wants to send a patch, I can apply it, but I don't see the 
motivation to revert.

Regards,

Anthony Liguori

> Stefan
>
>