From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzVqd-0000kU-Fg for qemu-devel@nongnu.org; Fri, 02 Sep 2011 11:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzVqb-0001mr-Q2 for qemu-devel@nongnu.org; Fri, 02 Sep 2011 11:40:03 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:60787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzVqb-0001mP-NA for qemu-devel@nongnu.org; Fri, 02 Sep 2011 11:40:01 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p82FFouc026401 for ; Fri, 2 Sep 2011 11:15:50 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p82Fe0fq226714 for ; Fri, 2 Sep 2011 11:40:00 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p82Bdk5P015289 for ; Fri, 2 Sep 2011 08:39:47 -0300 Message-ID: <4E60F8CB.9080707@us.ibm.com> Date: Fri, 02 Sep 2011 10:39:55 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314629736-13023-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Peter Maydell , qemu-devel@nongnu.org On 08/30/2011 02:24 PM, Blue Swirl wrote: > On Mon, Aug 29, 2011 at 2:55 PM, Anthony Liguori wrote: >> This has been discussed before in the past. The special casing really makes no >> sense anymore. This seems like a good change to make for 1.0. >> >> Signed-off-by: Anthony Liguori >> --- >> Makefile | 5 ++--- >> Makefile.target | 4 ---- >> 2 files changed, 2 insertions(+), 7 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 8606849..51ecdb5 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -365,9 +365,8 @@ tar: >> rm -rf /tmp/$(FILE) >> >> SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS)) >> -SYSTEM_PROGS=$(patsubst qemu-system-i386,qemu, \ >> - $(patsubst %-softmmu,qemu-system-%, \ >> - $(SYSTEM_TARGETS))) >> +SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \ >> + $(SYSTEM_TARGETS)) > > Maybe the patsubst could be avoided, just rename the build directory > from *-softmmu to qemu-system-* while at it? > >> >> USER_TARGETS=$(filter %-user,$(TARGET_DIRS)) >> USER_PROGS=$(patsubst %-bsd-user,qemu-%, \ > > Also here the directory and executable names could be made to match. I thought that historically the phrase softmmu was for the variant of libcpu that had an emulated TLB. I know Peter's been talking about a linux-user mode that uses softmmu since certain combinations of architectures today are impossible with linux-user (ia64 on x86_64 for instance). So I think the current naming conventions probably are reasonable although I'm not opposed to changing them. I think that should be a separate patch though. Regards, Anthony Liguori > >> diff --git a/Makefile.target b/Makefile.target >> index 07af4d4..29287ed 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -27,12 +27,8 @@ ifdef CONFIG_USER_ONLY >> QEMU_PROG=qemu-$(TARGET_ARCH2) >> else >> # system emulator name >> -ifeq ($(TARGET_ARCH), i386) >> -QEMU_PROG=qemu$(EXESUF) >> -else >> QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF) >> endif >> -endif >> >> PROGS=$(QEMU_PROG) >> STPFILES= >> -- >> 1.7.4.1 >> >> > >