From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzWL0-00030X-NK for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:11:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzWKz-00009z-Gk for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:11:26 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:59635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzWKz-00009s-EF for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:11:25 -0400 Received: by yih10 with SMTP id 10so2552060yih.4 for ; Fri, 02 Sep 2011 09:11:24 -0700 (PDT) Message-ID: <4E61002A.3020302@codemonkey.ws> Date: Fri, 02 Sep 2011 11:11:22 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314211389-28915-1-git-send-email-aliguori@us.ibm.com> <1314211389-28915-12-git-send-email-aliguori@us.ibm.com> <20110825103248.01753efa@doriath> In-Reply-To: <20110825103248.01753efa@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/14] qapi: add change-vnc-listen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , Anthony Liguori , qemu-devel@nongnu.org, Michael Roth On 08/25/2011 08:32 AM, Luiz Capitulino wrote: > On Wed, 24 Aug 2011 13:43:06 -0500 > Anthony Liguori wrote: > >> New QMP only command to change the VNC server's listening address. >> >> Signed-off-by: Anthony Liguori >> --- >> qapi-schema.json | 14 ++++++++++++++ >> qmp-commands.hx | 8 ++++++++ >> qmp.c | 7 +++++++ >> 3 files changed, 29 insertions(+), 0 deletions(-) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 3b2229f..211200a 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -109,3 +109,17 @@ >> # string. Existing clients are unaffected by executing this command. >> ## >> { 'command': 'change-vnc-password', 'data': {'password': 'str'} } >> + >> +## >> +# @change-vnc-listen: >> +# >> +# Change the host that the VNC server listens on. >> +# >> +# @target: the new server specification to listen on >> +# >> +# Since: 1.0 >> +# >> +# Notes: At this moment in time, the behavior of existing client connections >> +# when this command is executed is undefined. >> +## > > What's the expected behaviour wrt authentication? Right now it will disable > any authentication set for the previous address. It should at least be noted > in the documentation if that's expected. Indeed. Thanks. Regards, Anthony Liguori > >> +{ 'command': 'change-vnc-listen', 'data': {'target': 'str'} } >> diff --git a/qmp-commands.hx b/qmp-commands.hx >> index d60f72f..c0d0ca3 100644 >> --- a/qmp-commands.hx >> +++ b/qmp-commands.hx >> @@ -876,6 +876,14 @@ EQMP >> }, >> >> { >> + .name = "change-vnc-listen", >> + .args_type = "target:s", >> + .params = "target", >> + .help = "set vnc listening address", >> + .mhandler.cmd_new = qmp_marshal_input_change_vnc_listen, >> + }, >> + >> + { >> .name = "set_password", >> .args_type = "protocol:s,password:s,connected:s?", >> .params = "protocol password action-if-connected", >> diff --git a/qmp.c b/qmp.c >> index f817a88..73d6172 100644 >> --- a/qmp.c >> +++ b/qmp.c >> @@ -35,3 +35,10 @@ void qmp_change_vnc_password(const char *password, Error **err) >> error_set(err, QERR_SET_PASSWD_FAILED); >> } >> } >> + >> +void qmp_change_vnc_listen(const char *target, Error **err) >> +{ >> + if (vnc_display_open(NULL, target)< 0) { >> + error_set(err, QERR_VNC_SERVER_FAILED, target); >> + } >> +} > >