From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44971)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QzWPY-0005IF-4c
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:16:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QzWPX-0001Pe-87
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:16:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16651)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QzWPX-0001PN-0w
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:16:07 -0400
Message-ID: <4E6101F2.6000108@redhat.com>
Date: Fri, 02 Sep 2011 18:18:58 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1312376904-16115-1-git-send-email-armbru@redhat.com>
	<1312376904-16115-28-git-send-email-armbru@redhat.com>
	<4E60CB56.5080904@redhat.com>
	<m38vq7dkit.fsf@blackfin.pond.sub.org>
In-Reply-To: <m38vq7dkit.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 27/45] scsi-disk: Preserve tray state on
 migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: stefano.stabellini@eu.citrix.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de

Am 02.09.2011 17:35, schrieb Markus Armbruster:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
>> Am 03.08.2011 15:08, schrieb Markus Armbruster:
>>> Breaks migration of qdevs "scsi-cd" and legacy "scsi-disk" to older
>>> versions.  We normally use subsections to avoid that.  Not possible
>>> here, because we don't have a section to begin with.  Too bad.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> A more logical approach would be to add migration support to SCSI first.
> 
> Isn't that what I do?
> 
>> I guess adding .unmigratable = 1 makes more sense at the moment.
> 
> Why?

Hm, you mean that we can successfully migrate SCSI today?

SCSIDiskState doesn't seem to directly have anything variable that must
be migrated. I think SCSIDevice does have fields that need to be
migrated (unit_attention, sense and the request list). I'm not sure what
other state scsi-bus involves, but unless the SCSI controllers can
restore all of it, it should have a VMState, too.

Kevin