From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49734)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QzWTJ-00071H-ID
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:20:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QzWTI-0002Vw-GY
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:20:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53727)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QzWTI-0002Vs-6b
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:20:00 -0400
Message-ID: <4E6102DC.1050305@redhat.com>
Date: Fri, 02 Sep 2011 18:22:52 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1312376904-16115-1-git-send-email-armbru@redhat.com>
	<1312376904-16115-38-git-send-email-armbru@redhat.com>
	<4E60D453.30004@redhat.com> <m3sjofeze4.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3sjofeze4.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 37/45] block: Show whether the guest
 ejected the medium in info block
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: stefano.stabellini@eu.citrix.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de

Am 02.09.2011 17:29, schrieb Markus Armbruster:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
>> Am 03.08.2011 15:08, schrieb Markus Armbruster:
>>> Need to ask the device, so this requires new BlockDevOps member
>>> is_medium_ejected().
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> I find the name confusing. "medium is ejected" seems to mean "tray is
>> open". It isn't obvious that "tray is closed, but no medium is inserted"
>> is not "medium is ejected".
>>
>> Why not call it tray_open like in the devices?
> 
> Not all all devices with removable media have trays.  I'll rename it
> anyway.  We'll figure out how to handle devices without trays when we
> add one.

Then you need to clarify the intended semantics. For devices without a
tray it's completely unclear to me what it means. The example for such a
device that we have today is floppy.

Kevin