From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzWVp-0000y6-1R for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:22:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzWVn-00036E-U4 for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:22:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzWVn-000368-Jn for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:22:35 -0400 Message-ID: <4E610377.7050708@redhat.com> Date: Fri, 02 Sep 2011 18:25:27 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1312376904-16115-1-git-send-email-armbru@redhat.com> <1312376904-16115-42-git-send-email-armbru@redhat.com> <4E60D692.40105@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 41/45] block: New bdrv_set_buffer_alignment() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: stefano.stabellini@eu.citrix.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de Am 02.09.2011 17:30, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 03.08.2011 15:08, schrieb Markus Armbruster: >>> Device models should be able to set it without an unclean include of >>> block_int.h. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> block.c | 6 ++++-- >>> block.h | 1 + >>> hw/ide/core.c | 2 +- >>> hw/scsi-disk.c | 2 +- >>> hw/virtio-blk.c | 3 +-- >>> 5 files changed, 8 insertions(+), 6 deletions(-) >>> >>> diff --git a/block.c b/block.c >>> index fed0c16..67d9429 100644 >>> --- a/block.c >>> +++ b/block.c >>> @@ -453,7 +453,6 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filename, >>> bs->encrypted = 0; >>> bs->valid_key = 0; >>> bs->open_flags = flags; >>> - /* buffer_alignment defaulted to 512, drivers can change this value */ >>> bs->buffer_alignment = 512; >> >> This comment is still right. > > It's also next to useless. I hate comments paraphrasing the code :) > > I'll keep it if you insist. The information that the comment gives isn't that we set it to 512, but that this is only a default and "drivers" (should be "devices", I think) are expected to change it. Kevin