From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QzWsU-0007fa-1P
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:46:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QzWsT-0000GI-2X
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:46:02 -0400
Received: from e4.ny.us.ibm.com ([32.97.182.144]:47958)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1QzWsT-0000F3-04
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 12:46:01 -0400
Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237])
	by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p82GM9cA004770
	for <qemu-devel@nongnu.org>; Fri, 2 Sep 2011 12:22:09 -0400
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p82GjXtC188830
	for <qemu-devel@nongnu.org>; Fri, 2 Sep 2011 12:45:33 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p82CjIL2002119
	for <qemu-devel@nongnu.org>; Fri, 2 Sep 2011 09:45:20 -0300
Message-ID: <4E610828.8050007@us.ibm.com>
Date: Fri, 02 Sep 2011 11:45:28 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1314211389-28915-1-git-send-email-aliguori@us.ibm.com>	<1314211389-28915-4-git-send-email-aliguori@us.ibm.com>	<4E567724.7020601@linux.vnet.ibm.com>	<4E60FDB2.7060708@codemonkey.ws>	<20110902130931.50b0f63a@doriath>
	<4E6104F5.6010202@linux.vnet.ibm.com>
In-Reply-To: <4E6104F5.6010202@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/14] qapi: use middle mode in QMP server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 09/02/2011 11:31 AM, Michael Roth wrote:

>>> This ended up being a bit harder than I initially thought so I'd prefer
>>> to delay this to another series so we can start converting commands to
>>> QAPI ASAP.
>>
>> Fine with me.
>
> Same. Curious what the complications are though, I wouldn't mind looking
> at it.

The current dispatch and error checking logic in the QMP server scares 
me.  It wasn't immediately obvious if just adding another else clause in 
the dispatch logic was enough.

I could be wrong though.

Regards,

Anthony Liguori