From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0FQr-00007g-W8
	for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:20:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0FQq-0003NS-Vf
	for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:20:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12202)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0FQq-0003NO-NE
	for qemu-devel@nongnu.org; Sun, 04 Sep 2011 12:20:28 -0400
Message-ID: <4E63A548.10907@redhat.com>
Date: Sun, 04 Sep 2011 19:20:24 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <CAAu8pHsw1cTK7u+FNevgWUC2J8jxLSuSmjtF=wR5Ae8mk9eibA@mail.gmail.com>
In-Reply-To: <CAAu8pHsw1cTK7u+FNevgWUC2J8jxLSuSmjtF=wR5Ae8mk9eibA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/9] lsi53c895a: avoid a warning from clang
 analyzer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/04/2011 06:53 PM, Blue Swirl wrote:
> Avoid this warning from clang analyzer by adjusting the scope
> of the variable:
> /src/qemu/hw/lsi53c895a.c:895:5: warning: Value stored to 'id' is never read
>      id = (current_tag>>  8)&  0xf;
>
> Signed-off-by: Blue Swirl<blauwirbel@gmail.com>
> ---
>   hw/lsi53c895a.c |   14 ++++++++------
>   1 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
> index 1643a63..9d900d0 100644
> --- a/hw/lsi53c895a.c
> +++ b/hw/lsi53c895a.c
> @@ -883,7 +883,6 @@ static void lsi_do_msgout(LSIState *s)
>       int len;
>       uint32_t current_tag;
>       lsi_request *current_req, *p, *p_next;
> -    int id;
>
>       if (s->current) {
>           current_tag = s->current->tag;
> @@ -892,7 +891,6 @@ static void lsi_do_msgout(LSIState *s)
>           current_tag = s->select_tag;
>           current_req = lsi_find_by_tag(s, current_tag);
>       }
> -    id = (current_tag>>  8)&  0xf;
>
>       DPRINTF("MSG out len=%d\n", s->dbc);
>       while (s->dbc) {
> @@ -977,10 +975,14 @@ static void lsi_do_msgout(LSIState *s)
>                  device, but this is currently not implemented (and seems not
>                  to be really necessary). So let's simply clear all queued
>                  commands for the current device: */
> -            id = current_tag&  0x0000ff00;
> -            QTAILQ_FOREACH_SAFE(p,&s->queue, next, p_next) {
> -                if ((p->tag&  0x0000ff00) == id) {
> -                    scsi_req_cancel(p->req);
> +            {
> +                int id;
> +
> +                id = current_tag&  0x0000ff00;
> +                QTAILQ_FOREACH_SAFE(p,&s->queue, next, p_next) {
> +                    if ((p->tag&  0x0000ff00) == id) {
> +                        scsi_req_cancel(p->req);
> +                    }
>                   }
>               }
>

Why not keep id declared in the outer scope?  This extra indentation is 
annoying.


-- 
error compiling committee.c: too many arguments to function