From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56584)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0RqE-0008Ch-Do
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 01:35:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0RqD-00043w-Fj
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 01:35:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30376)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R0RqD-00043i-7F
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 01:35:29 -0400
Message-ID: <4E645F9C.6060504@redhat.com>
Date: Mon, 05 Sep 2011 08:35:24 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <CAAu8pHsw1cTK7u+FNevgWUC2J8jxLSuSmjtF=wR5Ae8mk9eibA@mail.gmail.com>
	<4E63A548.10907@redhat.com>
	<CAAu8pHuDV09PNXbLDx7Jb1=hwHtQwEdk92Z_Rf_pGe3A4w=pCw@mail.gmail.com>
In-Reply-To: <CAAu8pHuDV09PNXbLDx7Jb1=hwHtQwEdk92Z_Rf_pGe3A4w=pCw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/9] lsi53c895a: avoid a warning from clang
 analyzer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/04/2011 07:27 PM, Blue Swirl wrote:
> >>                   to be really necessary). So let's simply clear all queued
> >>                   commands for the current device: */
> >>  -            id = current_tag&    0x0000ff00;
> >>  -            QTAILQ_FOREACH_SAFE(p,&s->queue, next, p_next) {
> >>  -                if ((p->tag&    0x0000ff00) == id) {
> >>  -                    scsi_req_cancel(p->req);
> >>  +            {
> >>  +                int id;
> >>  +
> >>  +                id = current_tag&    0x0000ff00;
> >>  +                QTAILQ_FOREACH_SAFE(p,&s->queue, next, p_next) {
> >>  +                    if ((p->tag&    0x0000ff00) == id) {
> >>  +                        scsi_req_cancel(p->req);
> >>  +                    }
> >>                    }
> >>                }
> >>
> >
> >  Why not keep id declared in the outer scope?  This extra indentation is
> >  annoying.
>
> Also the variable could be dropped altogether simply with:
>                  if ((p->tag&  0x0000ff00) == (current_tag&  0x0000ff00)) {
>
> I have no preference.

Yet another option is to allow intermixing declarations and statements 
(which C99 allows), though it tends to get some traditionalists worked up.

It's particularly nice in for () loops.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.