From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R0Sye-0005Aw-Oo
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 02:48:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R0Syb-0007ut-VG
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 02:48:16 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E6470AB.1080402@redhat.com>
Date: Mon, 05 Sep 2011 08:48:11 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAAu8pHtJefidoG2-rFFOVScKgztMdy=-tD2HF-MvEhRmWxZuwQ@mail.gmail.com>
In-Reply-To: <CAAu8pHtJefidoG2-rFFOVScKgztMdy=-tD2HF-MvEhRmWxZuwQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 7/9] openpic: avoid a warning from clang
	analyzer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-ppc@nongnu.org, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On 09/04/2011 05:52 PM, Blue Swirl wrote:
> Avoid this warning by clang analyzer by defining a default case:
> /src/qemu/hw/openpic.c:477:5: warning: Undefined or garbage value
> returned to caller
>      return retval;
>
> Signed-off-by: Blue Swirl<blauwirbel@gmail.com>
> ---
>   hw/openpic.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/openpic.c b/hw/openpic.c
> index 26c96e2..4b883ac 100644
> --- a/hw/openpic.c
> +++ b/hw/openpic.c
> @@ -469,6 +469,7 @@ static inline uint32_t read_IRQreg (openpic_t
> *opp, int n_IRQ, uint32_t reg)
>       case IRQ_IPVP:
>           retval = opp->src[n_IRQ].ipvp;
>           break;
> +    default:
>       case IRQ_IDE:
>           retval = opp->src[n_IRQ].ide;
>           break;

Looks wrong, perhaps it should return 0?

Paolo