* [Qemu-devel] [PATCH 2/9] qemu-io: remove unnecessary assignment
@ 2011-09-04 15:47 Blue Swirl
2011-09-05 8:19 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Blue Swirl @ 2011-09-04 15:47 UTC (permalink / raw)
To: qemu-devel, Kevin Wolf
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
Remove an unnecessary assignment, spotted by clang analyzer:
/src/qemu/qemu-io.c:995:9: warning: Value stored to 'offset' is never read
offset += reqs[i].qiov->size;
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
qemu-io.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 7e40c48..5e46213 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -992,7 +992,6 @@ static int multiwrite_f(int argc, char **argv)
optind = j + 1;
- offset += reqs[i].qiov->size;
pattern++;
}
--
1.6.2.4
[-- Attachment #2: 0002-qemu-io-remove-unnecessary-assignment.patch --]
[-- Type: text/x-diff, Size: 1056 bytes --]
From f092cf2775a0398a3267100ff0c8cd3caac5d5d6 Mon Sep 17 00:00:00 2001
Message-Id: <f092cf2775a0398a3267100ff0c8cd3caac5d5d6.1315150286.git.blauwirbel@gmail.com>
In-Reply-To: <70f99a25b7732d4c9ea54f74c089ccb9bb323ea6.1315150286.git.blauwirbel@gmail.com>
References: <70f99a25b7732d4c9ea54f74c089ccb9bb323ea6.1315150286.git.blauwirbel@gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 4 Sep 2011 10:38:01 +0000
Subject: [PATCH 2/9] qemu-io: remove unnecessary assignment
Remove an unnecessary assignment, spotted by clang analyzer:
/src/qemu/qemu-io.c:995:9: warning: Value stored to 'offset' is never read
offset += reqs[i].qiov->size;
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
qemu-io.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 7e40c48..5e46213 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -992,7 +992,6 @@ static int multiwrite_f(int argc, char **argv)
optind = j + 1;
- offset += reqs[i].qiov->size;
pattern++;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH 2/9] qemu-io: remove unnecessary assignment
2011-09-04 15:47 [Qemu-devel] [PATCH 2/9] qemu-io: remove unnecessary assignment Blue Swirl
@ 2011-09-05 8:19 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2011-09-05 8:19 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
Am 04.09.2011 17:47, schrieb Blue Swirl:
> Remove an unnecessary assignment, spotted by clang analyzer:
> /src/qemu/qemu-io.c:995:9: warning: Value stored to 'offset' is never read
> offset += reqs[i].qiov->size;
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-05 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-04 15:47 [Qemu-devel] [PATCH 2/9] qemu-io: remove unnecessary assignment Blue Swirl
2011-09-05 8:19 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).