From: Kevin Wolf <kwolf@redhat.com>
To: Sage Weil <sage@newdream.net>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] rbd: fix leak in qemu_rbd_open failure paths
Date: Mon, 05 Sep 2011 14:32:43 +0200 [thread overview]
Message-ID: <4E64C16B.5040501@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1109040918340.28858@cobra.newdream.net>
Am 04.09.2011 18:19, schrieb Sage Weil:
> Fix leak of s->snap in failure path. Simplify error paths for the whole
> function.
>
> Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
> Signed-off-by: Sage Weil <sage@newdream.net>
This depends on "[PATCH v2] rbd: allow client id to be specified in
config string", which doesn't seem to apply any more and has coding
style issues. Please fix and send a rebased series containing all four
patches.
Kevin
prev parent reply other threads:[~2011-09-05 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 16:28 [Qemu-devel] [PATCH 1/3] rbd: fix leak in failure path Sage Weil
2011-08-23 16:28 ` [Qemu-devel] [PATCH 2/3] rbd: allow client id to be specified in config string Sage Weil
2011-09-02 14:12 ` Stefan Hajnoczi
2011-08-23 16:28 ` [Qemu-devel] [PATCH 3/3] rbd: clean up, fix style Sage Weil
2011-09-02 14:14 ` Stefan Hajnoczi
2011-09-02 14:10 ` [Qemu-devel] [PATCH 1/3] rbd: fix leak in failure path Stefan Hajnoczi
2011-09-03 22:04 ` [Qemu-devel] [PATCH v2] rbd: fix leak in qemu_rbd_open failure paths Sage Weil
2011-09-04 11:24 ` Stefan Hajnoczi
2011-09-04 16:18 ` Sage Weil
2011-09-04 16:19 ` [Qemu-devel] [PATCH v3] " Sage Weil
2011-09-04 18:20 ` Stefan Hajnoczi
2011-09-05 12:32 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E64C16B.5040501@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sage@newdream.net \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).