From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44101)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R0Ze4-00045S-IR
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 09:55:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R0Ze3-0000yh-H0
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 09:55:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R0Ze3-0000yU-A1
	for qemu-devel@nongnu.org; Mon, 05 Sep 2011 09:55:27 -0400
Message-ID: <4E64D4C5.6050202@redhat.com>
Date: Mon, 05 Sep 2011 15:55:17 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1314370059.git.jan.kiszka@siemens.com>	<6ffbd56b9b714a41c021499a50ecac8e7a8e022b.1314370059.git.jan.kiszka@siemens.com>	<CAFEAcA_RKE7F7r1Ox4g=g0GmuK=d+FyTguX0tHu1smcgKnJ2WA@mail.gmail.com>	<4E57BA82.703@siemens.com>
	<4E57C011.4040103@siemens.com>
In-Reply-To: <4E57C011.4040103@siemens.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] required glib version? Re: [PATCH 2/6] Add base64
	encoder/decoder
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On 08/26/11 17:47, Jan Kiszka wrote:
> On 2011-08-26 17:23, Jan Kiszka wrote:

>> [ using glib base64 decoder ]
>
> Requires glib>= 2.12, we are currently at>= 2.0, right? Would it be OK
> to raise the entry barrier?

In master it currently is >= 2.20 due to v9fs_init_worker_threads using 
g_thread_get_initialized which was added in 2.20 according to the docs. 
  Which makes the build fail on rhel-5 (shipping with glib 2.12).

Guess we'll need to clearly define which minimum glib version we want 
require.  And whenever we want apply this to the whole code base or 
allow different minimum requirements for different components.

Requiring glib 2.20 for all components isn't going to fly as we 
certainly want be able to run the qemu guest agent almost everythere. 
Requiring something newer than 2.0 for the qemu emulator might be 
reasonable of there are good reasons (aka useful glib features) though.

Comments?

cheers,
   Gerd