qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments
Date: Mon, 05 Sep 2011 23:17:31 +0200	[thread overview]
Message-ID: <4E653C6B.9010106@web.de> (raw)
In-Reply-To: <CAAu8pHsU=B-JL2Np6TJqOtJgsSD1RR=76mrNazkuo2k3BZNfxQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On 2011-09-05 21:45, Blue Swirl wrote:
> On Mon, Sep 5, 2011 at 3:37 PM, Stefan Hajnoczi
> <stefanha@linux.vnet.ibm.com> wrote:
>> String arguments are useful for producing human-readable traces without
>> post-processing (e.g. stderr backend).  Although the simple backend
>> cannot handles strings all others can.  Strings should be allowed and
>> the simple backend can be extended to support them.
> 
> I don't think this is possible in general. Yes if the string can be
> found in the executable (assuming address space randomizations don't
> make that impossible post run), but not if the string happens to be
> constructed in the stack or in the data segment during run time.

Strings can be addressed in tracers like simpletrace by storing a
fixed-size copy (e.g. 64 chars) in the log. That will work out for the
majority of use cases.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2011-09-05 21:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 15:37 [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments Stefan Hajnoczi
2011-09-05 15:37 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: add tracing subsystem Stefan Hajnoczi
2011-09-05 19:45 ` [Qemu-devel] [PATCH 1/2] trace: allow trace events with string arguments Blue Swirl
2011-09-05 21:17   ` Jan Kiszka [this message]
2011-09-06 14:24   ` Stefan Hajnoczi
2011-09-07 19:21     ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E653C6B.9010106@web.de \
    --to=jan.kiszka@web.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).