qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Brad <brad@comstyle.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags.
Date: Tue, 06 Sep 2011 12:19:21 +0200	[thread overview]
Message-ID: <4E65F3A9.80905@redhat.com> (raw)
In-Reply-To: <20110906080245.GA26732@rox.home.comstyle.com>

On 09/06/11 10:02, Brad wrote:
> Only build with -g CFLAGS/LDFLAGS if using --enable-debug.
> Add --optflags to allow overriding the default optimization
> level added to CFLAGS.
>
> This is a first draft of coming up with a patch I could potentially
> push upstream based on much cruder local patches to do something
> similar. I'm trying to eliminate having to patch the configure
> script.

You don't have to.  You can just run 'make CFLAGS="$optflags"' to 
override the defaults.  Nevertheless having optflags would be nice as 
you don't have to type this for each make run then.

I don't think we should mess with the -g flag.  It should stay enabled 
by default, so you can easily get a useful stacktrace out of a core 
without having to rebuild with debug info first.

cheers,
   Gerd

  parent reply	other threads:[~2011-09-06 10:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06  8:02 [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags Brad
2011-09-06  9:26 ` Peter Maydell
2011-09-06 10:19 ` Gerd Hoffmann [this message]
2011-09-06 16:30   ` Brad
2011-09-07 10:54     ` Juan Quintela
2011-09-07 19:42       ` Blue Swirl
2011-09-07 21:31     ` Stefan Weil
2011-09-06 10:35 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E65F3A9.80905@redhat.com \
    --to=kraxel@redhat.com \
    --cc=brad@comstyle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).