From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0ska-00027L-JQ for qemu-devel@nongnu.org; Tue, 06 Sep 2011 06:19:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0skZ-00058S-N4 for qemu-devel@nongnu.org; Tue, 06 Sep 2011 06:19:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0skZ-00058L-G2 for qemu-devel@nongnu.org; Tue, 06 Sep 2011 06:19:27 -0400 Message-ID: <4E65F3A9.80905@redhat.com> Date: Tue, 06 Sep 2011 12:19:21 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <20110906080245.GA26732@rox.home.comstyle.com> In-Reply-To: <20110906080245.GA26732@rox.home.comstyle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Only build with -g CFLAGS/LDFLAGS if using --enable-debug and add --optflags. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Cc: qemu-devel@nongnu.org On 09/06/11 10:02, Brad wrote: > Only build with -g CFLAGS/LDFLAGS if using --enable-debug. > Add --optflags to allow overriding the default optimization > level added to CFLAGS. > > This is a first draft of coming up with a patch I could potentially > push upstream based on much cruder local patches to do something > similar. I'm trying to eliminate having to patch the configure > script. You don't have to. You can just run 'make CFLAGS="$optflags"' to override the defaults. Nevertheless having optflags would be nice as you don't have to type this for each make run then. I don't think we should mess with the -g flag. It should stay enabled by default, so you can easily get a useful stacktrace out of a core without having to rebuild with debug info first. cheers, Gerd