qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Fam Zheng <famcool@gmail.com>, qemu-devel@nongnu.org, hch@lst.de
Subject: Re: [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support
Date: Tue, 06 Sep 2011 12:40:20 +0200	[thread overview]
Message-ID: <4E65F894.30509@redhat.com> (raw)
In-Reply-To: <20110905081548.GA23026@stefanha-thinkpad.localdomain>

Am 05.09.2011 10:15, schrieb Stefan Hajnoczi:
> On Fri, Aug 12, 2011 at 11:19:26PM +0800, Fam Zheng wrote:
>> Changes:
>>     02/06: Free extents on fail in vmdk_open.
>>     
>> Added:
>>     07/08: VMDK: bugfix, open Haiku vmdk image
>>     08/08: VMDK: bugfix, opening vSphere 4 exported image
>>
>> Fam Zheng (8):
>>   VMDK: enable twoGbMaxExtentFlat
>>   VMDK: add twoGbMaxExtentSparse support
>>   VMDK: separate vmdk_read_extent/vmdk_write_extent
>>   VMDK: Opening compressed extent.
>>   VMDK: read/write compressed extent
>>   VMDK: creating streamOptimized subformat
>>   VMDK: bugfix, open Haiku vmdk image
>>   VMDK: bugfix, opening vSphere 4 exported image
>>
>>  block/vmdk.c |  346 +++++++++++++++++++++++++++++++++++++++++++++-------------
>>  1 files changed, 270 insertions(+), 76 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

I saw that in some places the result of bdrv_pread/pwrite is thrown away
and -EIO is returned instead. Please fix this on top of this series to
return the real error code.

Kevin

      reply	other threads:[~2011-09-06 10:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 15:19 [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support Fam Zheng
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 1/8] VMDK: enable twoGbMaxExtentFlat Fam Zheng
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 2/8] VMDK: add twoGbMaxExtentSparse support Fam Zheng
2011-09-06 10:38   ` Kevin Wolf
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 3/8] VMDK: separate vmdk_read_extent/vmdk_write_extent Fam Zheng
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 4/8] VMDK: Opening compressed extent Fam Zheng
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 5/8] VMDK: read/write " Fam Zheng
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 6/8] VMDK: creating streamOptimized subformat Fam Zheng
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 7/8] VMDK: bugfix, open Haiku vmdk image Fam Zheng
2011-08-12 15:19 ` [Qemu-devel] [PATCH v3 8/8] VMDK: bugfix, opening vSphere 4 exported image Fam Zheng
2011-09-05  8:15 ` [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support Stefan Hajnoczi
2011-09-06 10:40   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E65F894.30509@redhat.com \
    --to=kwolf@redhat.com \
    --cc=famcool@gmail.com \
    --cc=hch@lst.de \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).