From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0t1z-0000wP-L7 for qemu-devel@nongnu.org; Tue, 06 Sep 2011 06:37:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0t1x-00088S-U3 for qemu-devel@nongnu.org; Tue, 06 Sep 2011 06:37:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0t1x-00088F-Jv for qemu-devel@nongnu.org; Tue, 06 Sep 2011 06:37:25 -0400 Message-ID: <4E65F894.30509@redhat.com> Date: Tue, 06 Sep 2011 12:40:20 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1313162374-13147-1-git-send-email-famcool@gmail.com> <20110905081548.GA23026@stefanha-thinkpad.localdomain> In-Reply-To: <20110905081548.GA23026@stefanha-thinkpad.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/8] Add various VMDK subformats support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Fam Zheng , qemu-devel@nongnu.org, hch@lst.de Am 05.09.2011 10:15, schrieb Stefan Hajnoczi: > On Fri, Aug 12, 2011 at 11:19:26PM +0800, Fam Zheng wrote: >> Changes: >> 02/06: Free extents on fail in vmdk_open. >> >> Added: >> 07/08: VMDK: bugfix, open Haiku vmdk image >> 08/08: VMDK: bugfix, opening vSphere 4 exported image >> >> Fam Zheng (8): >> VMDK: enable twoGbMaxExtentFlat >> VMDK: add twoGbMaxExtentSparse support >> VMDK: separate vmdk_read_extent/vmdk_write_extent >> VMDK: Opening compressed extent. >> VMDK: read/write compressed extent >> VMDK: creating streamOptimized subformat >> VMDK: bugfix, open Haiku vmdk image >> VMDK: bugfix, opening vSphere 4 exported image >> >> block/vmdk.c | 346 +++++++++++++++++++++++++++++++++++++++++++++------------- >> 1 files changed, 270 insertions(+), 76 deletions(-) > > Reviewed-by: Stefan Hajnoczi Thanks, applied to the block branch. I saw that in some places the result of bdrv_pread/pwrite is thrown away and -EIO is returned instead. Please fix this on top of this series to return the real error code. Kevin