From: Christian Borntraeger <borntraeger@de.ibm.com>
To: agraf@suse.de
Cc: Carsten Otte <cotte@de.ibm.com>,
programming.philipp.muens@googlemail.com,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels
Date: Tue, 06 Sep 2011 13:41:39 +0200 [thread overview]
Message-ID: <4E6606F3.5020102@de.ibm.com> (raw)
Alex,
Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x10000.
(e.g. current linux-next). We must not rely on specific code at certain
addresses, so lets just remove this check.
Reported-by: Philipp Muens <programming.philipp.muens@googlemail.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
hw/s390-virtio.c | 5 -----
1 file changed, 5 deletions(-)
Index: b/hw/s390-virtio.c
===================================================================
--- a/hw/s390-virtio.c
+++ b/hw/s390-virtio.c
@@ -193,11 +193,6 @@ static void s390_init(ram_addr_t my_ram_
if (kernel_filename) {
kernel_size = load_image(kernel_filename, qemu_get_ram_ptr(0));
- if (lduw_be_phys(KERN_IMAGE_START) != 0x0dd0) {
- fprintf(stderr, "Specified image is not an s390 boot image\n");
- exit(1);
- }
-
env->psw.addr = KERN_IMAGE_START;
env->psw.mask = 0x0000000180000000ULL;
} else {
next reply other threads:[~2011-09-06 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 11:41 Christian Borntraeger [this message]
2011-09-07 11:56 ` [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels Alexander Graf
2011-09-07 12:33 ` Christian Borntraeger
2011-09-07 12:34 ` Alexander Graf
2011-09-08 14:48 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6606F3.5020102@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cotte@de.ibm.com \
--cc=programming.philipp.muens@googlemail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).