From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded
Date: Tue, 06 Sep 2011 11:08:41 -0500 [thread overview]
Message-ID: <4E664589.6090601@codemonkey.ws> (raw)
In-Reply-To: <4E6644D5.4060103@siemens.com>
On 09/06/2011 11:05 AM, Jan Kiszka wrote:
> On 2011-09-06 17:51, Anthony Liguori wrote:
>> I'm still contemplating how we go about doing this. This series
>> introduces a couple new concepts like QMP class hinting anonymous IDs.
>> I'm concerned that we'll further complicate the need to support
>> backwards compatibility.
>
> Anonymous IDs must not be considered stable. If you prefer, we could try
> to filter them out for QMP use. Need to check though if there is a good
> location to catch them, but the rule is trivial.
>
> I will also happily drop anonymous IDs again once we have converted all
> devices to stable QOM full path addressing. But that will simply take
> too much time to wait for it I'm afraid.
>
>>
>> Would the command be useful if you couldn't address devices? If it just
>> dumped the full machine state all at once? That would at least obviate
>> the need to add anonymous IDs.
>
> Theoretically usable, but extremely unhandy. I would not like so see
> such an interface exposed to users.
What about just taking the device type (iow the savevm section name)?
In most scenarios, it's probably easier for a user and will still only
have a single match.
Regards,
Anthony Liguori
>
> Jan
>
next prev parent reply other threads:[~2011-09-06 16:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 14:48 [Qemu-devel] [PATCH 0/6] Device state visualization reloaded Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 1/6] monitor: return length of printed string via monitor_[v]printf Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 2/6] Add base64 encoder/decoder Jan Kiszka
2011-08-26 15:21 ` Peter Maydell
2011-08-26 15:23 ` Jan Kiszka
2011-08-26 15:47 ` Jan Kiszka
2011-08-26 18:02 ` Jan Kiszka
2011-09-02 17:22 ` Luiz Capitulino
2011-09-05 13:55 ` [Qemu-devel] required glib version? " Gerd Hoffmann
2011-08-26 14:48 ` [Qemu-devel] [PATCH 3/6] QMP: Reserve namespace for complex object classes Jan Kiszka
2011-09-02 17:23 ` Luiz Capitulino
2011-09-02 17:47 ` Jan Kiszka
2011-09-02 18:02 ` Anthony Liguori
2011-08-26 14:48 ` [Qemu-devel] [PATCH 4/6] QMP: Add QBuffer Jan Kiszka
2011-08-26 18:23 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 5/6] monitor: Add basic device state visualization Jan Kiszka
2011-08-26 14:48 ` [Qemu-devel] [PATCH 6/6] qdev: Generate IDs for anonymous devices Jan Kiszka
2011-08-29 19:23 ` Anthony Liguori
2011-08-29 20:56 ` Jan Kiszka
2011-08-29 21:19 ` Anthony Liguori
2011-08-31 18:31 ` Jan Kiszka
2011-09-07 9:50 ` Gleb Natapov
2011-09-07 10:27 ` Jan Kiszka
2011-09-07 10:34 ` Gleb Natapov
2011-09-07 10:58 ` Jan Kiszka
2011-08-29 19:22 ` [Qemu-devel] [PATCH 0/6] Device state visualization reloaded Anthony Liguori
2011-08-29 20:54 ` Jan Kiszka
2011-09-02 17:27 ` Luiz Capitulino
2011-09-06 14:48 ` Michael S. Tsirkin
2011-09-06 15:45 ` Jan Kiszka
2011-09-06 15:51 ` Anthony Liguori
2011-09-06 16:05 ` Jan Kiszka
2011-09-06 16:08 ` Anthony Liguori [this message]
2011-09-06 16:33 ` Jan Kiszka
2011-09-06 16:09 ` Michael S. Tsirkin
2011-09-06 16:28 ` Anthony Liguori
2011-09-06 17:05 ` Michael S. Tsirkin
2011-09-07 9:37 ` Kevin Wolf
2011-09-07 13:06 ` Michael S. Tsirkin
2011-09-07 13:13 ` Jan Kiszka
2011-09-07 13:17 ` Michael S. Tsirkin
2011-09-07 13:23 ` Anthony Liguori
2011-09-07 13:29 ` Jan Kiszka
2011-09-07 13:33 ` Michael S. Tsirkin
2011-09-06 16:29 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E664589.6090601@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).