From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R0yCf-0008NK-Ia
	for qemu-devel@nongnu.org; Tue, 06 Sep 2011 12:08:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R0yCa-0001fY-Db
	for qemu-devel@nongnu.org; Tue, 06 Sep 2011 12:08:49 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:37855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R0yCa-0001fT-9p
	for qemu-devel@nongnu.org; Tue, 06 Sep 2011 12:08:44 -0400
Received: by gxk26 with SMTP id 26so4108456gxk.4
	for <qemu-devel@nongnu.org>; Tue, 06 Sep 2011 09:08:43 -0700 (PDT)
Message-ID: <4E664589.6090601@codemonkey.ws>
Date: Tue, 06 Sep 2011 11:08:41 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1314370059.git.jan.kiszka@siemens.com>	<20110906144828.GA20834@redhat.com>	<4E66402C.2020900@siemens.com>
	<4E66417E.6040308@codemonkey.ws> <4E6644D5.4060103@siemens.com>
In-Reply-To: <4E6644D5.4060103@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 09/06/2011 11:05 AM, Jan Kiszka wrote:
> On 2011-09-06 17:51, Anthony Liguori wrote:
>> I'm still contemplating how we go about doing this.  This series
>> introduces a couple new concepts like QMP class hinting anonymous IDs.
>> I'm concerned that we'll further complicate the need to support
>> backwards compatibility.
>
> Anonymous IDs must not be considered stable. If you prefer, we could try
> to filter them out for QMP use. Need to check though if there is a good
> location to catch them, but the rule is trivial.
>
> I will also happily drop anonymous IDs again once we have converted all
> devices to stable QOM full path addressing. But that will simply take
> too much time to wait for it I'm afraid.
>
>>
>> Would the command be useful if you couldn't address devices?  If it just
>> dumped the full machine state all at once?  That would at least obviate
>> the need to add anonymous IDs.
>
> Theoretically usable, but extremely unhandy. I would not like so see
> such an interface exposed to users.

What about just taking the device type (iow the savevm section name)?

In most scenarios, it's probably easier for a user and will still only 
have a single match.

Regards,

Anthony Liguori

>
> Jan
>