qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Drake <adrake@adrake.org>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH] mips: Fix incorrect jump instruction in YAMON mini-bootloader print function.
Date: Tue, 6 Sep 2011 16:41:56 -0400	[thread overview]
Message-ID: <4E668594.4060207@adrake.org> (raw)

The print function is listed in the vector table as 0xbfc00808. The backedge
of the loop is improperly encoded, and so jumps to 0xb0000814 instead of the
desired 0xbfc00814.

Signed-off-by: Andrew Drake <adrake@adrake.org>
---
  hw/mips_malta.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index a0adb56..d4820c3 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -605,7 +605,7 @@ static void write_bootloader (CPUState *env, uint8_t *base,
      stl_raw(p++, 0x00000000);                                     /* nop */
      stl_raw(p++, 0x0ff0021c);                                     /* jal 870 */
      stl_raw(p++, 0x00000000);                                     /* nop */
-    stl_raw(p++, 0x08000205);                                     /* j 814 */
+    stl_raw(p++, 0x0bf00205);                                     /* j 814 */
      stl_raw(p++, 0x00000000);                                     /* nop */
      stl_raw(p++, 0x01a00008);                                     /* jr t5 */
      stl_raw(p++, 0x01602021);                                     /* move a0,t3 */
-- 
1.7.1

                 reply	other threads:[~2011-09-06 21:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E668594.4060207@adrake.org \
    --to=adrake@adrake.org \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).