From: Jan Kiszka <jan.kiszka@siemens.com>
To: Bharata B Rao <bharata.rao@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [FIX] X86 CPU topology broken in KVM mode
Date: Wed, 07 Sep 2011 10:33:30 +0200 [thread overview]
Message-ID: <4E672C5A.2010906@siemens.com> (raw)
In-Reply-To: <CAGZKiBrAjj0Em1oNix4GFXZLDSz1f2Hk03AEDedkF4nrUEevbg@mail.gmail.com>
On 2011-09-07 10:19, Bharata B Rao wrote:
> On Wed, Sep 7, 2011 at 1:37 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2011-09-07 06:21, Bharata B Rao wrote:
>>> - I am not sure what is the problem with i486 as I haven't been able
>>> to boot an i486 VM successfully, hence haven't attempted to fix this.
>>
>> -smp 2 -cpu i486 boots fine here (granted, I don't have some i486 SMP
>> kernel at hand).
>
> I am getting "Unable to find x86 CPU definition" error with -cpu i486.
> Need to investigate more.
Err, sorry: -cpu 486
>
>>> +
>>> + if (env->cpuid_features & CPUID_APIC) {
>>
>> || smp_cpus > 1
>>
>> Should be obvious when looking at the hunk you took this from.
>
> Yes, but I thought no harm in initializing it for uni processor case too, no ?
486 CPUs do not have the CPUID_APIC feature set as they do not include a
local APIC. But those SMP systems have external APICs.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-09-07 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 4:21 [Qemu-devel] [FIX] X86 CPU topology broken in KVM mode Bharata B Rao
2011-09-07 8:07 ` Jan Kiszka
2011-09-07 8:19 ` Bharata B Rao
2011-09-07 8:33 ` Jan Kiszka [this message]
2011-09-07 12:59 ` Anthony Liguori
2011-09-07 13:24 ` Bharata B Rao
2011-09-07 13:29 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E672C5A.2010906@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=bharata.rao@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).