From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1DZf-0000te-ES for qemu-devel@nongnu.org; Wed, 07 Sep 2011 04:33:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1DZe-0006vx-4n for qemu-devel@nongnu.org; Wed, 07 Sep 2011 04:33:35 -0400 Received: from goliath.siemens.de ([192.35.17.28]:23433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1DZd-0006vY-Ra for qemu-devel@nongnu.org; Wed, 07 Sep 2011 04:33:34 -0400 Message-ID: <4E672C5A.2010906@siemens.com> Date: Wed, 07 Sep 2011 10:33:30 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E672654.7070701@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [FIX] X86 CPU topology broken in KVM mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: "qemu-devel@nongnu.org" , Avi Kivity On 2011-09-07 10:19, Bharata B Rao wrote: > On Wed, Sep 7, 2011 at 1:37 PM, Jan Kiszka wrote: >> On 2011-09-07 06:21, Bharata B Rao wrote: >>> - I am not sure what is the problem with i486 as I haven't been able >>> to boot an i486 VM successfully, hence haven't attempted to fix this. >> >> -smp 2 -cpu i486 boots fine here (granted, I don't have some i486 SMP >> kernel at hand). > > I am getting "Unable to find x86 CPU definition" error with -cpu i486. > Need to investigate more. Err, sorry: -cpu 486 > >>> + >>> + if (env->cpuid_features & CPUID_APIC) { >> >> || smp_cpus > 1 >> >> Should be obvious when looking at the hunk you took this from. > > Yes, but I thought no harm in initializing it for uni processor case too, no ? 486 CPUs do not have the CPUID_APIC feature set as they do not include a local APIC. But those SMP systems have external APICs. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux