From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>,
programming.philipp.muens@googlemail.com,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels
Date: Wed, 07 Sep 2011 14:33:19 +0200 [thread overview]
Message-ID: <4E67648F.70100@de.ibm.com> (raw)
In-Reply-To: <CF1E07CE-D394-4F95-8CAA-02E753FE2973@suse.de>
On 07/09/11 13:56, Alexander Graf wrote:
>
> On 06.09.2011, at 13:41, Christian Borntraeger wrote:
>
>> Alex,
>>
>> Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x10000.
>> (e.g. current linux-next). We must not rely on specific code at certain
>> addresses, so lets just remove this check.
>
> Is there any other sane way we can find out if the image we're loading is
> actually bootable? I don't want users to do qemu-system-s390x -kernel
> vmlinux and see it just plain fail.
No, in theory it could change arbitrarily. The vmlinux case is unfortunate
but in the end its "shoot yourself in the foot", we just have to make sure
that we allow a graceful exit from a looping qemu guest.
Christian
next prev parent reply other threads:[~2011-09-07 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 11:41 [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels Christian Borntraeger
2011-09-07 11:56 ` Alexander Graf
2011-09-07 12:33 ` Christian Borntraeger [this message]
2011-09-07 12:34 ` Alexander Graf
2011-09-08 14:48 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E67648F.70100@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cotte@de.ibm.com \
--cc=programming.philipp.muens@googlemail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).