From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1QD8-00040I-HE for qemu-devel@nongnu.org; Wed, 07 Sep 2011 18:03:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1QD7-0002C0-07 for qemu-devel@nongnu.org; Wed, 07 Sep 2011 18:03:10 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:41169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1QD6-0002Bp-T5 for qemu-devel@nongnu.org; Wed, 07 Sep 2011 18:03:08 -0400 Received: by ywf9 with SMTP id 9so135559ywf.4 for ; Wed, 07 Sep 2011 15:03:08 -0700 (PDT) Message-ID: <4E67EA19.5080200@codemonkey.ws> Date: Wed, 07 Sep 2011 17:03:05 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314984898-19141-1-git-send-email-aliguori@us.ibm.com> <19806608-2700-48EE-B1A0-492745A61D86@suse.de> In-Reply-To: <19806608-2700-48EE-B1A0-492745A61D86@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Kevin Wolf , Michael Roth , Anthony Liguori , qemu-devel@nongnu.org, Luiz Capitulino On 09/07/2011 04:56 PM, Alexander Graf wrote: > > On 02.09.2011, at 19:34, Anthony Liguori wrote: > >> This is my attempt to jump-start the QAPI switch over. All of the hard work >> is already done in my qapi branch, we just need to start merging stuff. >> >> To simplify the merge process, I've introduced a new mode to the code generator >> that lets us do conversions without using the new QMP server. >> >> Once this series is merged, anything that touchs QMP (to modify a command or >> add a new command) must do it through QAPI--no exceptions. >> >> This series also includes Dans change to the 'change' command. I'm not thrilled >> about people using this command but its better to err on the side of caution. >> It's now officially deprecated with much more robust replacement commands. >> >> Since v1, I've tried to address all review comments. I've also tested the >> modified commands extensively. > > Just stumbled over this while trying to build. Smells like missing Makefile dependencies (works just fine with -j1), but I figured I'd give you a heads up on this. It's a fresh checkout with nothing done but ./configure; make -j. > > > agraf@e77:/dev/shm/qemu> make -j > GEN i386-softmmu/config-devices.mak > GEN arm-softmmu/config-devices.mak > GEN x86_64-softmmu/config-devices.mak > GEN cris-softmmu/config-devices.mak > GEN lm32-softmmu/config-devices.mak > GEN m68k-softmmu/config-devices.mak > GEN microblaze-softmmu/config-devices.mak > GEN microblazeel-softmmu/config-devices.mak > GEN mips-softmmu/config-devices.mak > GEN mipsel-softmmu/config-devices.mak > GEN mips64-softmmu/config-devices.mak > GEN mips64el-softmmu/config-devices.mak > GEN ppcemb-softmmu/config-devices.mak > GEN ppc-softmmu/config-devices.mak > GEN ppc64-softmmu/config-devices.mak > GEN sh4-softmmu/config-devices.mak > GEN sh4eb-softmmu/config-devices.mak > GEN sparc-softmmu/config-devices.mak > GEN sparc64-softmmu/config-devices.mak > GEN i386-linux-user/config-devices.mak > GEN s390x-softmmu/config-devices.mak > GEN x86_64-linux-user/config-devices.mak > GEN alpha-linux-user/config-devices.mak > GEN arm-linux-user/config-devices.mak > GEN armeb-linux-user/config-devices.mak > GEN cris-linux-user/config-devices.mak > GEN m68k-linux-user/config-devices.mak > GEN microblaze-linux-user/config-devices.mak > GEN microblazeel-linux-user/config-devices.mak > GEN mips-linux-user/config-devices.mak > GEN mipsel-linux-user/config-devices.mak > GEN ppc-linux-user/config-devices.mak > GEN ppc64-linux-user/config-devices.mak > GEN sh4-linux-user/config-devices.mak > GEN ppc64abi32-linux-user/config-devices.mak > GEN sh4eb-linux-user/config-devices.mak > GEN sparc64-linux-user/config-devices.mak > GEN sparc32plus-linux-user/config-devices.mak > GEN unicore32-linux-user/config-devices.mak > GEN sparc-linux-user/config-devices.mak > GEN s390x-linux-user/config-devices.mak > GEN config-all-devices.mak > GEN config-host.h > GEN trace.h > GEN qemu-options.def > GEN qapi-generated/qga-qapi-visit.h > GEN trace.c > CC trace/default.o > CC trace/control.o > GEN qemu-img-cmds.h > cc1: error: qapi-generated: No such file or directory > cc1: error: qapi-generated: No such file or directory I've seen this before too but this is due to guest-agent, not this patch series. Mike, have you seen this before? Regards, Anthony Liguori > make: *** [trace/default.o] Error 1 > make: *** Waiting for unfinished jobs.... > make: *** [trace/control.o] Error 1 > > >