From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1RIN-0006SV-4U for qemu-devel@nongnu.org; Wed, 07 Sep 2011 19:12:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1RIL-0003lh-Ex for qemu-devel@nongnu.org; Wed, 07 Sep 2011 19:12:39 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:46630) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1RIL-0003lM-93 for qemu-devel@nongnu.org; Wed, 07 Sep 2011 19:12:37 -0400 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p87Mv1IX023101 for ; Wed, 7 Sep 2011 16:57:01 -0600 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p87NCSXk152752 for ; Wed, 7 Sep 2011 17:12:28 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p87NCShw031585 for ; Wed, 7 Sep 2011 17:12:28 -0600 Message-ID: <4E67FA59.8060202@linux.vnet.ibm.com> Date: Wed, 07 Sep 2011 18:12:25 -0500 From: Michael Roth MIME-Version: 1.0 References: <1314984898-19141-1-git-send-email-aliguori@us.ibm.com> <19806608-2700-48EE-B1A0-492745A61D86@suse.de> <4E67EA19.5080200@codemonkey.ws> <4E67EF1D.6020104@us.ibm.com> In-Reply-To: <4E67EF1D.6020104@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/15] Convert commands to QAPI (batch 1) (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , qemu-devel@nongnu.org, Alexander Graf , Luiz Capitulino On 09/07/2011 05:24 PM, Anthony Liguori wrote: > On 09/07/2011 05:04 PM, Alexander Graf wrote: >> >> On 08.09.2011, at 00:03, Anthony Liguori wrote: >> >>> On 09/07/2011 04:56 PM, Alexander Graf wrote: >>>> >>>> On 02.09.2011, at 19:34, Anthony Liguori wrote: >>>> >>>>> This is my attempt to jump-start the QAPI switch over. All of the >>>>> hard work >>>>> is already done in my qapi branch, we just need to start merging >>>>> stuff. >>>>> >>>>> To simplify the merge process, I've introduced a new mode to the >>>>> code generator >>>>> that lets us do conversions without using the new QMP server. >>>>> >>>>> Once this series is merged, anything that touchs QMP (to modify a >>>>> command or >>>>> add a new command) must do it through QAPI--no exceptions. >>>>> >>>>> This series also includes Dans change to the 'change' command. I'm >>>>> not thrilled >>>>> about people using this command but its better to err on the side >>>>> of caution. >>>>> It's now officially deprecated with much more robust replacement >>>>> commands. >>>>> >>>>> Since v1, I've tried to address all review comments. I've also >>>>> tested the >>>>> modified commands extensively. >>>> >>>> Just stumbled over this while trying to build. Smells like missing >>>> Makefile dependencies (works just fine with -j1), but I figured I'd >>>> give you a heads up on this. It's a fresh checkout with nothing done >>>> but ./configure; make -j. >>>> >>>> >>>> agraf@e77:/dev/shm/qemu> make -j >>>> GEN i386-softmmu/config-devices.mak >>>> GEN arm-softmmu/config-devices.mak >>>> GEN x86_64-softmmu/config-devices.mak >>>> GEN cris-softmmu/config-devices.mak >>>> GEN lm32-softmmu/config-devices.mak >>>> GEN m68k-softmmu/config-devices.mak >>>> GEN microblaze-softmmu/config-devices.mak >>>> GEN microblazeel-softmmu/config-devices.mak >>>> GEN mips-softmmu/config-devices.mak >>>> GEN mipsel-softmmu/config-devices.mak >>>> GEN mips64-softmmu/config-devices.mak >>>> GEN mips64el-softmmu/config-devices.mak >>>> GEN ppcemb-softmmu/config-devices.mak >>>> GEN ppc-softmmu/config-devices.mak >>>> GEN ppc64-softmmu/config-devices.mak >>>> GEN sh4-softmmu/config-devices.mak >>>> GEN sh4eb-softmmu/config-devices.mak >>>> GEN sparc-softmmu/config-devices.mak >>>> GEN sparc64-softmmu/config-devices.mak >>>> GEN i386-linux-user/config-devices.mak >>>> GEN s390x-softmmu/config-devices.mak >>>> GEN x86_64-linux-user/config-devices.mak >>>> GEN alpha-linux-user/config-devices.mak >>>> GEN arm-linux-user/config-devices.mak >>>> GEN armeb-linux-user/config-devices.mak >>>> GEN cris-linux-user/config-devices.mak >>>> GEN m68k-linux-user/config-devices.mak >>>> GEN microblaze-linux-user/config-devices.mak >>>> GEN microblazeel-linux-user/config-devices.mak >>>> GEN mips-linux-user/config-devices.mak >>>> GEN mipsel-linux-user/config-devices.mak >>>> GEN ppc-linux-user/config-devices.mak >>>> GEN ppc64-linux-user/config-devices.mak >>>> GEN sh4-linux-user/config-devices.mak >>>> GEN ppc64abi32-linux-user/config-devices.mak >>>> GEN sh4eb-linux-user/config-devices.mak >>>> GEN sparc64-linux-user/config-devices.mak >>>> GEN sparc32plus-linux-user/config-devices.mak >>>> GEN unicore32-linux-user/config-devices.mak >>>> GEN sparc-linux-user/config-devices.mak >>>> GEN s390x-linux-user/config-devices.mak >>>> GEN config-all-devices.mak >>>> GEN config-host.h >>>> GEN trace.h >>>> GEN qemu-options.def >>>> GEN qapi-generated/qga-qapi-visit.h >>>> GEN trace.c >>>> CC trace/default.o >>>> CC trace/control.o >>>> GEN qemu-img-cmds.h >>>> cc1: error: qapi-generated: No such file or directory >>>> cc1: error: qapi-generated: No such file or directory >>> >>> I've seen this before too but this is due to guest-agent, not this >>> patch series. >> >> Ah, sorry, didn't track down what exactly was going wrong where and >> figured since it fails on qapi, it'd be related :) > > I assume the root cause is that qapi-generated is being generated by > make instead of by configure. Mike, care to throw together a quick patch Yah, QGA's code generators create qapi-generated/, and that code doesn't execute until a dependency on GENERATED_HEADERS is met. So it seems there was a pre-existing race to begin with, which got exacerbated by e4858974ec36afd8a6b3a9e2b0ad8f357f28efc7 which is missing some deps on GENERATED_HEADERS, so it got in more ahead of the code generation scripts than we'd seen previously. > to change that? Then there's no guess work tracking down dependencies. > Sure, ill send that in a few. Looks like will still get make -j build failures from that tracing patch though so I'll look at that as well. > Regards, > > Anthony Liguori > >> Alex >> >