From: Kevin Wolf <kwolf@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg
Date: Thu, 08 Sep 2011 12:16:19 +0200 [thread overview]
Message-ID: <4E6895F3.5010706@redhat.com> (raw)
In-Reply-To: <4E6893F1.8070004@redhat.com>
Am 08.09.2011 12:07, schrieb Avi Kivity:
> On 09/07/2011 09:44 PM, Anthony Liguori wrote:
>>
>> I think this is a bit more complicated than is really needed. Here's
>> what I came up with which also fixes another bug where the io channel
>> could be freed twice. I stumbled across this via a very strange
>> failure scenario. Avi, it might be worth trying this patch to see if
>> it fixes your problem too.
>
> Right now, I've got more than just one problem.
>
>>
>> One thing that I found challenging debugging this, coroutines make
>> valgrind very unhappy. Is it possible that we could have a command
>> line switch to fall back to the thread based coroutines so to make
>> things more valgrind friendly?
>
> How is valgrind even aware of coroutines? Unless is doesn't implement
> makecontext correctly, it shouldn't even be aware of them.
The F15 valgrind complains three times that the program is switching
stacks, but then it shuts up and just works as normal.
Kevin
next prev parent reply other threads:[~2011-09-08 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 12:30 [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg Aneesh Kumar K.V
2011-09-07 18:44 ` Anthony Liguori
2011-09-07 19:26 ` Aneesh Kumar K.V
2011-09-08 10:07 ` Avi Kivity
2011-09-08 10:16 ` Kevin Wolf [this message]
2011-09-08 12:57 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6895F3.5010706@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).