From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1bbq-0000Hw-6z
	for qemu-devel@nongnu.org; Thu, 08 Sep 2011 06:13:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1bbn-0004D6-Um
	for qemu-devel@nongnu.org; Thu, 08 Sep 2011 06:13:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1bbn-0004D2-Ma
	for qemu-devel@nongnu.org; Thu, 08 Sep 2011 06:13:23 -0400
Message-ID: <4E6895F3.5010706@redhat.com>
Date: Thu, 08 Sep 2011 12:16:19 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1315398653-29945-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
	<4E67BB97.8070306@us.ibm.com> <4E6893F1.8070004@redhat.com>
In-Reply-To: <4E6893F1.8070004@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler
 to work with null	call back arg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Am 08.09.2011 12:07, schrieb Avi Kivity:
> On 09/07/2011 09:44 PM, Anthony Liguori wrote:
>>
>> I think this is a bit more complicated than is really needed.  Here's 
>> what I came up with which also fixes another bug where the io channel 
>> could be freed twice.  I stumbled across this via a very strange 
>> failure scenario.  Avi, it might be worth trying this patch to see if 
>> it fixes your problem too.
> 
> Right now, I've got more than just one problem.
> 
>>
>> One thing that I found challenging debugging this, coroutines make 
>> valgrind very unhappy.  Is it possible that we could have a command 
>> line switch to fall back to the thread based coroutines so to make 
>> things more valgrind friendly?
> 
> How is valgrind even aware of coroutines?  Unless is doesn't implement 
> makecontext correctly, it shouldn't even be aware of them.

The F15 valgrind complains three times that the program is switching
stacks, but then it shuts up and just works as normal.

Kevin