From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1dPZ-0004zW-Jw for qemu-devel@nongnu.org; Thu, 08 Sep 2011 08:08:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R1dPY-0000A2-Sg for qemu-devel@nongnu.org; Thu, 08 Sep 2011 08:08:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R1dPY-00009y-KS for qemu-devel@nongnu.org; Thu, 08 Sep 2011 08:08:52 -0400 Message-ID: <4E68B104.3020408@redhat.com> Date: Thu, 08 Sep 2011 14:11:48 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1315481922-4690-1-git-send-email-freddy77@gmail.com> In-Reply-To: <1315481922-4690-1-git-send-email-freddy77@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: initialize metadata before inserting in cluster_allocs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frediano Ziglio Cc: qemu-devel@nongnu.org Am 08.09.2011 13:38, schrieb Frediano Ziglio: > QCow2Meta structure was inserted into list before many fields are > initialized. Currently is not a problem cause all occur in a lock > but if qcow2_alloc_clusters would in a future unlock this lock > some issues could arise. > Initializing fields before inserting fix the problem. > > Signed-off-by: Frediano Ziglio Thanks, applied to the block branch. Kevin