From: Stefan Weil <weil@mail.berlios.de>
To: qemu-trivial <qemu-trivial@nongnu.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code
Date: Thu, 08 Sep 2011 18:17:08 +0200 [thread overview]
Message-ID: <4E68EA84.3020204@mail.berlios.de> (raw)
In-Reply-To: <87aac9wakl.fsf@linux.vnet.ibm.com>
Am 20.07.2011 11:44, schrieb Aneesh Kumar K.V:
> On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil <weil@mail.berlios.de>
> wrote:
>> This error was reported by cppcheck:
>>
>> qemu/hw/9pfs/virtio-9p-debug.c:342:
>> error: Invalid number of character ({) when these macros are defined:
>> 'DEBUG_DATA'.
>>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>> hw/9pfs/virtio-9p-debug.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/9pfs/virtio-9p-debug.c b/hw/9pfs/virtio-9p-debug.c
>> index 4636ad5..96925f0 100644
>> --- a/hw/9pfs/virtio-9p-debug.c
>> +++ b/hw/9pfs/virtio-9p-debug.c
>> @@ -295,7 +295,7 @@ static void pprint_data(V9fsPDU *pdu, int rx,
>> size_t *offsetp, const char *name)
>>
>> if (rx) {
>> count = pdu->elem.in_num;
>> - } else
>> + } else {
>> count = pdu->elem.out_num;
>> }
>>
>
> Applied.
>
> We also need to update virtio-9p-debug w.r.t the new co-routine
> series. With co-routine we can have multiple 9p handler started
> simultaneously.
>
> -aneesh
Maybe this patch can be applied via qemu-trivial.
I simply would like to get it out of my list of open patches.
Thanks,
Stefan W.
next prev parent reply other threads:[~2011-09-08 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 6:27 [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code Stefan Weil
2011-07-20 9:44 ` Aneesh Kumar K.V
2011-09-08 16:17 ` Stefan Weil [this message]
2011-09-09 8:58 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E68EA84.3020204@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).