From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36733)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1R1hHu-0008Ab-9D
	for qemu-devel@nongnu.org; Thu, 08 Sep 2011 12:17:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1R1hHt-0002I9-Ch
	for qemu-devel@nongnu.org; Thu, 08 Sep 2011 12:17:14 -0400
Message-ID: <4E68EA84.3020204@mail.berlios.de>
Date: Thu, 08 Sep 2011 18:17:08 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1311143248-29509-1-git-send-email-weil@mail.berlios.de>
	<87aac9wakl.fsf@linux.vnet.ibm.com>
In-Reply-To: <87aac9wakl.fsf@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-trivial <qemu-trivial@nongnu.org>
Cc: qemu-devel@nongnu.org

Am 20.07.2011 11:44, schrieb Aneesh Kumar K.V:
> On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil <weil@mail.berlios.de> 
> wrote:
>> This error was reported by cppcheck:
>>
>> qemu/hw/9pfs/virtio-9p-debug.c:342:
>> error: Invalid number of character ({) when these macros are defined:
>> 'DEBUG_DATA'.
>>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>> hw/9pfs/virtio-9p-debug.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/9pfs/virtio-9p-debug.c b/hw/9pfs/virtio-9p-debug.c
>> index 4636ad5..96925f0 100644
>> --- a/hw/9pfs/virtio-9p-debug.c
>> +++ b/hw/9pfs/virtio-9p-debug.c
>> @@ -295,7 +295,7 @@ static void pprint_data(V9fsPDU *pdu, int rx, 
>> size_t *offsetp, const char *name)
>>
>> if (rx) {
>> count = pdu->elem.in_num;
>> - } else
>> + } else {
>> count = pdu->elem.out_num;
>> }
>>
>
> Applied.
>
> We also need to update virtio-9p-debug w.r.t the new co-routine
> series. With co-routine we can have multiple 9p handler started
> simultaneously.
>
> -aneesh

Maybe this patch can be applied via qemu-trivial.
I simply would like to get it out of my list of open patches.

Thanks,
Stefan W.