* [Qemu-devel] [PATCH] ahci: Remove unused struct member
@ 2011-09-08 19:44 Stefan Weil
2011-09-09 9:15 ` Kevin Wolf
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2011-09-08 19:44 UTC (permalink / raw)
To: qemu-devel
Member variable is_read is written, but never read
(contrary to its name). Remove it.
Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hw/ide/ahci.c | 2 --
hw/ide/ahci.h | 1 -
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index f4fa154..a8659cf 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -754,7 +754,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
case READ_FPDMA_QUEUED:
DPRINTF(port, "NCQ reading %d sectors from LBA %ld, tag %d\n",
ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
- ncq_tfs->is_read = 1;
DPRINTF(port, "tag %d aio read %ld\n", ncq_tfs->tag, ncq_tfs->lba);
@@ -768,7 +767,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
case WRITE_FPDMA_QUEUED:
DPRINTF(port, "NCQ writing %d sectors to LBA %ld, tag %d\n",
ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
- ncq_tfs->is_read = 0;
DPRINTF(port, "tag %d aio write %ld\n", ncq_tfs->tag, ncq_tfs->lba);
diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
index 3c29d93..5de986c 100644
--- a/hw/ide/ahci.h
+++ b/hw/ide/ahci.h
@@ -259,7 +259,6 @@ typedef struct NCQTransferState {
BlockDriverAIOCB *aiocb;
QEMUSGList sglist;
BlockAcctCookie acct;
- int is_read;
uint16_t sector_count;
uint64_t lba;
uint8_t tag;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ahci: Remove unused struct member
2011-09-08 19:44 [Qemu-devel] [PATCH] ahci: Remove unused struct member Stefan Weil
@ 2011-09-09 9:15 ` Kevin Wolf
2011-09-09 9:43 ` Alexander Graf
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Wolf @ 2011-09-09 9:15 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel, Alexander Graf
Am 08.09.2011 21:44, schrieb Stefan Weil:
> Member variable is_read is written, but never read
> (contrary to its name).
Nice commit message :-)
> Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/ide/ahci.c | 2 --
> hw/ide/ahci.h | 1 -
> 2 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index f4fa154..a8659cf 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -754,7 +754,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
> case READ_FPDMA_QUEUED:
> DPRINTF(port, "NCQ reading %d sectors from LBA %ld, tag %d\n",
> ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
> - ncq_tfs->is_read = 1;
>
> DPRINTF(port, "tag %d aio read %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>
> @@ -768,7 +767,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
> case WRITE_FPDMA_QUEUED:
> DPRINTF(port, "NCQ writing %d sectors to LBA %ld, tag %d\n",
> ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
> - ncq_tfs->is_read = 0;
>
> DPRINTF(port, "tag %d aio write %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>
> diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
> index 3c29d93..5de986c 100644
> --- a/hw/ide/ahci.h
> +++ b/hw/ide/ahci.h
> @@ -259,7 +259,6 @@ typedef struct NCQTransferState {
> BlockDriverAIOCB *aiocb;
> QEMUSGList sglist;
> BlockAcctCookie acct;
> - int is_read;
> uint16_t sector_count;
> uint64_t lba;
> uint8_t tag;
Alex, any specific reason you introduced it for? Is it unnecessary or is
it a bug that it has no user?
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ahci: Remove unused struct member
2011-09-09 9:15 ` Kevin Wolf
@ 2011-09-09 9:43 ` Alexander Graf
2011-09-09 11:22 ` Kevin Wolf
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Graf @ 2011-09-09 9:43 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On 09.09.2011, at 11:15, Kevin Wolf wrote:
> Am 08.09.2011 21:44, schrieb Stefan Weil:
>> Member variable is_read is written, but never read
>> (contrary to its name).
>
> Nice commit message :-)
>
>> Kevin Wolf <kwolf@redhat.com>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>> hw/ide/ahci.c | 2 --
>> hw/ide/ahci.h | 1 -
>> 2 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
>> index f4fa154..a8659cf 100644
>> --- a/hw/ide/ahci.c
>> +++ b/hw/ide/ahci.c
>> @@ -754,7 +754,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
>> case READ_FPDMA_QUEUED:
>> DPRINTF(port, "NCQ reading %d sectors from LBA %ld, tag %d\n",
>> ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
>> - ncq_tfs->is_read = 1;
>>
>> DPRINTF(port, "tag %d aio read %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>>
>> @@ -768,7 +767,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
>> case WRITE_FPDMA_QUEUED:
>> DPRINTF(port, "NCQ writing %d sectors to LBA %ld, tag %d\n",
>> ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
>> - ncq_tfs->is_read = 0;
>>
>> DPRINTF(port, "tag %d aio write %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>>
>> diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
>> index 3c29d93..5de986c 100644
>> --- a/hw/ide/ahci.h
>> +++ b/hw/ide/ahci.h
>> @@ -259,7 +259,6 @@ typedef struct NCQTransferState {
>> BlockDriverAIOCB *aiocb;
>> QEMUSGList sglist;
>> BlockAcctCookie acct;
>> - int is_read;
>> uint16_t sector_count;
>> uint64_t lba;
>> uint8_t tag;
>
> Alex, any specific reason you introduced it for? Is it unnecessary or is
> it a bug that it has no user?
This is a leftover from before the code went upstream. It can easily go away :)
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ahci: Remove unused struct member
2011-09-09 9:43 ` Alexander Graf
@ 2011-09-09 11:22 ` Kevin Wolf
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2011-09-09 11:22 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-devel
Am 09.09.2011 11:43, schrieb Alexander Graf:
>
> On 09.09.2011, at 11:15, Kevin Wolf wrote:
>
>> Am 08.09.2011 21:44, schrieb Stefan Weil:
>>> Member variable is_read is written, but never read
>>> (contrary to its name).
>>
>> Nice commit message :-)
>>
>>> Kevin Wolf <kwolf@redhat.com>
>>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>>> ---
>>> hw/ide/ahci.c | 2 --
>>> hw/ide/ahci.h | 1 -
>>> 2 files changed, 0 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
>>> index f4fa154..a8659cf 100644
>>> --- a/hw/ide/ahci.c
>>> +++ b/hw/ide/ahci.c
>>> @@ -754,7 +754,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
>>> case READ_FPDMA_QUEUED:
>>> DPRINTF(port, "NCQ reading %d sectors from LBA %ld, tag %d\n",
>>> ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
>>> - ncq_tfs->is_read = 1;
>>>
>>> DPRINTF(port, "tag %d aio read %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>>>
>>> @@ -768,7 +767,6 @@ static void process_ncq_command(AHCIState *s, int port, uint8_t *cmd_fis,
>>> case WRITE_FPDMA_QUEUED:
>>> DPRINTF(port, "NCQ writing %d sectors to LBA %ld, tag %d\n",
>>> ncq_tfs->sector_count-1, ncq_tfs->lba, ncq_tfs->tag);
>>> - ncq_tfs->is_read = 0;
>>>
>>> DPRINTF(port, "tag %d aio write %ld\n", ncq_tfs->tag, ncq_tfs->lba);
>>>
>>> diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h
>>> index 3c29d93..5de986c 100644
>>> --- a/hw/ide/ahci.h
>>> +++ b/hw/ide/ahci.h
>>> @@ -259,7 +259,6 @@ typedef struct NCQTransferState {
>>> BlockDriverAIOCB *aiocb;
>>> QEMUSGList sglist;
>>> BlockAcctCookie acct;
>>> - int is_read;
>>> uint16_t sector_count;
>>> uint64_t lba;
>>> uint8_t tag;
>>
>> Alex, any specific reason you introduced it for? Is it unnecessary or is
>> it a bug that it has no user?
>
> This is a leftover from before the code went upstream. It can easily go away :)
Great, thanks. Applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-09 11:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-08 19:44 [Qemu-devel] [PATCH] ahci: Remove unused struct member Stefan Weil
2011-09-09 9:15 ` Kevin Wolf
2011-09-09 9:43 ` Alexander Graf
2011-09-09 11:22 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).