From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1zG4-0006tg-Td
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 07:28:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1zG4-0008Iu-04
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 07:28:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45378)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R1zG3-0008Im-Ov
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 07:28:31 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p89BSU7Z017202
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 9 Sep 2011 07:28:31 -0400
Message-ID: <4E69F90F.2050702@redhat.com>
Date: Fri, 09 Sep 2011 13:31:27 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1315408862-15178-1-git-send-email-pbonzini@redhat.com>
	<1315408862-15178-2-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1315408862-15178-2-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/5] dma-helpers: rename is_write to to_dev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Am 07.09.2011 17:20, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  dma-helpers.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/dma-helpers.c b/dma-helpers.c
> index 4610ea0..ca97e14 100644
> --- a/dma-helpers.c
> +++ b/dma-helpers.c
> @@ -42,7 +42,7 @@ typedef struct {
>      BlockDriverAIOCB *acb;
>      QEMUSGList *sg;
>      uint64_t sector_num;
> -    int is_write;
> +    int to_dev;
>      int sg_cur_index;
>      target_phys_addr_t sg_cur_byte;
>      QEMUIOVector iov;

Should we take the opportunity to make it a bool? I think it would make
the purpose easier to understand.

Kevin