From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R25vM-0000BL-3h
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 14:35:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R25vL-00035O-4d
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 14:35:36 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:50475)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R25vK-00035K-Vb
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 14:35:35 -0400
Received: by gye5 with SMTP id 5so2170708gye.4
	for <qemu-devel@nongnu.org>; Fri, 09 Sep 2011 11:35:34 -0700 (PDT)
Message-ID: <4E6A5C73.6050206@codemonkey.ws>
Date: Fri, 09 Sep 2011 13:35:31 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <7d472e560b452ffba3f75ae364c2db709f7fab2d.1315558826.git.amit.shah@redhat.com>
In-Reply-To: <7d472e560b452ffba3f75ae364c2db709f7fab2d.1315558826.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] balloon: Disassociate handlers from
 balloon device on unplug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On 09/09/2011 04:00 AM, Amit Shah wrote:
> When a balloon device gets unplugged, allow the balloon handlers to be
> freed.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>

Applied all.  Thanks.

Regards,

Anthony Liguori

> ---
>   balloon.c |   10 ++++++++++
>   balloon.h |    1 +
>   2 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/balloon.c b/balloon.c
> index f56fdc1..a2133db 100644
> --- a/balloon.c
> +++ b/balloon.c
> @@ -52,6 +52,16 @@ int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
>       return 0;
>   }
>
> +void qemu_remove_balloon_handler(void *opaque)
> +{
> +    if (balloon_opaque != opaque) {
> +        return;
> +    }
> +    balloon_event_fn = NULL;
> +    balloon_stat_fn = NULL;
> +    balloon_opaque = NULL;
> +}
> +
>   static int qemu_balloon(ram_addr_t target)
>   {
>       if (!balloon_event_fn) {
> diff --git a/balloon.h b/balloon.h
> index 3df14e6..f59e288 100644
> --- a/balloon.h
> +++ b/balloon.h
> @@ -22,6 +22,7 @@ typedef void (QEMUBalloonStatus)(void *opaque, MonitorCompletion cb,
>
>   int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
>   			     QEMUBalloonStatus *stat_func, void *opaque);
> +void qemu_remove_balloon_handler(void *opaque);
>
>   void monitor_print_balloon(Monitor *mon, const QObject *data);
>   int do_info_balloon(Monitor *mon, MonitorCompletion cb, void *opaque);