From: Jan Kiszka <jan.kiszka@web.de>
To: Bharata B Rao <bharata.rao@gmail.com>
Cc: qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode
Date: Sun, 11 Sep 2011 10:02:10 +0200 [thread overview]
Message-ID: <4E6C6B02.7010505@web.de> (raw)
In-Reply-To: <CAGZKiBo-rS0Ek1J3=MDdmLwXDR67Z1ESkfRuPwKr0psKe3-LzQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]
On 2011-09-10 16:37, Bharata B Rao wrote:
> On Fri, Sep 9, 2011 at 10:44 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>>
>> This breaks the build:
>>
>> CC i386-linux-user/helper.o
>> /home/anthony/git/qemu/target-i386/helper.c: In function ‘cpu_x86_init’:
>> /home/anthony/git/qemu/target-i386/helper.c:1260:47: error: ‘smp_cpus’
>> undeclared (first use in this function)
>> /home/anthony/git/qemu/target-i386/helper.c:1260:47: note: each undeclared
>> identifier is reported only once for each function it appears in
>> make[1]: *** [helper.o] Error 1
>> make: *** [subdir-i386-linux-user] Error 2
>>
>> Please do a full build before submitting patches.
>
> Sorry about this, the complexity of qemu and its capability to
> support/emulate such wide range of targets is slowly sinking in :)
>
> smp_cpus is defined in vl.c which doesn't even get compiled for
> targets like i386-linux-user and hence we end up in above undefined
> reference error.
>
> I wouldn't attempt another fix until I spend some time understanding
> the code organization for various targets. Meanwhile since the root
> cause of the probem and the solution are known, if anyone more well
> versed with qemu code organization can fix this, please go ahead.
Just assign cpuid_apic_id unconditionally in cpu_x86_init. Will have no
side effects.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2011-09-11 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 5:33 [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode bharata.rao
2011-09-08 17:04 ` Jan Kiszka
2011-09-09 17:14 ` Anthony Liguori
2011-09-10 14:37 ` Bharata B Rao
2011-09-11 8:02 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6C6B02.7010505@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=bharata.rao@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).