From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39395)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R2ezc-0004bg-6f
	for qemu-devel@nongnu.org; Sun, 11 Sep 2011 04:02:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R2ezb-0006qZ-2u
	for qemu-devel@nongnu.org; Sun, 11 Sep 2011 04:02:20 -0400
Received: from fmmailgate03.web.de ([217.72.192.234]:39503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1R2eza-0006qE-IK
	for qemu-devel@nongnu.org; Sun, 11 Sep 2011 04:02:19 -0400
Message-ID: <4E6C6B02.7010505@web.de>
Date: Sun, 11 Sep 2011 10:02:10 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <1315460008-22657-1-git-send-email-bharata.rao@gmail.com>
	<4E6A4983.4010507@codemonkey.ws>
	<CAGZKiBo-rS0Ek1J3=MDdmLwXDR67Z1ESkfRuPwKr0psKe3-LzQ@mail.gmail.com>
In-Reply-To: <CAGZKiBo-rS0Ek1J3=MDdmLwXDR67Z1ESkfRuPwKr0psKe3-LzQ@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigACFA3198731F94E38E542B6C"
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bharata B Rao <bharata.rao@gmail.com>
Cc: qemu-devel@nongnu.org, avi@redhat.com

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigACFA3198731F94E38E542B6C
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 2011-09-10 16:37, Bharata B Rao wrote:
> On Fri, Sep 9, 2011 at 10:44 PM, Anthony Liguori <anthony@codemonkey.ws=
> wrote:
>>
>> This breaks the build:
>>
>>  CC    i386-linux-user/helper.o
>> /home/anthony/git/qemu/target-i386/helper.c: In function =91cpu_x86_in=
it=92:
>> /home/anthony/git/qemu/target-i386/helper.c:1260:47: error: =91smp_cpu=
s=92
>> undeclared (first use in this function)
>> /home/anthony/git/qemu/target-i386/helper.c:1260:47: note: each undecl=
ared
>> identifier is reported only once for each function it appears in
>> make[1]: *** [helper.o] Error 1
>> make: *** [subdir-i386-linux-user] Error 2
>>
>> Please do a full build before submitting patches.
>=20
> Sorry about this, the complexity of qemu and its capability to
> support/emulate such wide range of targets is slowly sinking in :)
>=20
> smp_cpus is defined in vl.c which doesn't even get compiled for
> targets like i386-linux-user and hence we end up in above undefined
> reference error.
>=20
> I wouldn't attempt another fix until I spend some time understanding
> the code organization for various targets. Meanwhile since the root
> cause of the probem and the solution are known, if anyone more well
> versed with qemu code organization can fix this, please go ahead.

Just assign cpuid_apic_id unconditionally in cpu_x86_init. Will have no
side effects.

Jan


--------------enigACFA3198731F94E38E542B6C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5sawcACgkQitSsb3rl5xTLAACfbhwsXe5+VNLIdG6irUFma2aa
+wwAoNV+qVofsRWeF8iOuJNM+apt6j0m
=WYBc
-----END PGP SIGNATURE-----

--------------enigACFA3198731F94E38E542B6C--