From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32fb-0000ma-NZ for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:19:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R32fa-00065v-LL for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:19:15 -0400 Received: from david.siemens.de ([192.35.17.14]:24950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32fa-00065o-4a for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:19:14 -0400 Message-ID: <4E6DCE8D.9040602@siemens.com> Date: Mon, 12 Sep 2011 11:19:09 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E6DAA09.1050701@twiddle.net> <4E6DCA61.4070009@siemens.com> <4E6DCCC4.1050201@redhat.com> In-Reply-To: <4E6DCCC4.1050201@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Blue Swirl , qemu-devel , Richard Henderson On 2011-09-12 11:11, Avi Kivity wrote: > On 09/12/2011 12:01 PM, Jan Kiszka wrote: >> On 2011-09-12 08:43, Richard Henderson wrote: >>> On 09/11/2011 09:31 PM, Blue Swirl wrote: >>>> Field 'offset' is always zero, maybe that is not interesting. Will it >>>> become one day? >>> >>> It's not always zero, but only used by certain devices. >> >> I do not see any users, neither upstream nor in Avi's tree. > > There aren't. > >> To my (semi-)understanding, offset should correlate to region_offset of >> cpu_register_physical_memory_offset: legacy device models require this >> to be 0 as they expect an absolute memory address passed to their >> handler, in contrast to a normal one that is relative to the regions >> base. But I do not see how the memory region offset actually helps here. >> > > mr->offset is added to the address in memory_region_{read,write}_thunk_n(). Ah, ok. So the default address passed to the handler is now already relative? I think we should keep it like this for all converted devices, ie. take the chance, fix the remaining models, and drop the offset. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux