From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R348y-0005qA-59
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 06:53:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R348x-0007RV-5X
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 06:53:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25929)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R348w-0007RQ-PQ
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 06:53:39 -0400
Message-ID: <4E6DE4AF.1050604@redhat.com>
Date: Mon, 12 Sep 2011 13:53:35 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <CAAu8pHvpbYBuOKa6Krsd6R00qidBx+J6ObaqZT40zuYh+SZn9g@mail.gmail.com>
	<4E6DE104.1090204@redhat.com>
In-Reply-To: <4E6DE104.1090204@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/12/2011 01:37 PM, Gerd Hoffmann wrote:
>> I/O
>> io addr 0000000000000000 off 0000000000000000 size 10000
>> -e1000-io addr 000000000000c000 off 0000000000000000 size 40
>> -piix-bmdma-container addr 000000000000c040 off 0000000000000000 size 10
>> --bmdma addr 000000000000000c off 0000000000000000 size 4
>> --piix-bmdma addr 0000000000000008 off 0000000000000000 size 4
>> --bmdma addr 0000000000000004 off 0000000000000000 size 4
>> --piix-bmdma addr 0000000000000000 off 0000000000000000 size 4
>> -pci-conf-data addr 0000000000000cfc off 0000000000000000 size 4
>> -pci-conf-idx addr 0000000000000cf8 off 0000000000000000 size 4
>
> Could you put the (variable-length) name field last?  That should make 
> the whole list more readable as the addresses are aligned then.
>

Makes sense.  Can adopt other features from /proc/iomem - like using 
start/end instead of start/length - makes it easier to see if an address 
fits in a range.

-- 
error compiling committee.c: too many arguments to function