From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R34Ts-0002eV-9B for qemu-devel@nongnu.org; Mon, 12 Sep 2011 07:15:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R34Tn-0003Bz-9T for qemu-devel@nongnu.org; Mon, 12 Sep 2011 07:15:15 -0400 Received: from mail-vx0-f173.google.com ([209.85.220.173]:58684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R34Tm-0003BI-IS for qemu-devel@nongnu.org; Mon, 12 Sep 2011 07:15:11 -0400 Received: by vxj15 with SMTP id 15so2545628vxj.4 for ; Mon, 12 Sep 2011 04:15:09 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E6DE9B9.9080407@redhat.com> Date: Mon, 12 Sep 2011 13:15:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1315818870-31575-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1315818870-31575-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: emulate .bdrv_flush() using .bdrv_aio_flush() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, Ronnie Sahlberg On 09/12/2011 11:14 AM, Stefan Hajnoczi wrote: > Block drivers typically have two copies of the flush operation: a > synchronous .bdrv_flush() and an asynchronous .bdrv_aio_flush(). This > patch applies the same emulation that we already do for > .bdrv_read()/.bdrv_write() to .bdrv_flush(). Now block drivers only > need to provide either .bdrv_aio_flush() or, in the case of legacy > drivers, .bdrv_flush(). I had the same bug in my nbd improvements series, so thanks. After Kevin merges this and parts 1-7 (or 1-9 even) of that series I'll resend. Paolo