From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50362)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R34mO-0006eV-Eg
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 07:34:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R34mN-0006bR-H8
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 07:34:24 -0400
Received: from mail-vw0-f53.google.com ([209.85.212.53]:36005)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R34mN-0006bM-Av
	for qemu-devel@nongnu.org; Mon, 12 Sep 2011 07:34:23 -0400
Received: by vws13 with SMTP id 13so3818438vws.12
	for <qemu-devel@nongnu.org>; Mon, 12 Sep 2011 04:34:22 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E6DEE3A.2000400@redhat.com>
Date: Mon, 12 Sep 2011 13:34:18 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1315168167-10654-1-git-send-email-hpoussin@reactos.org>
	<1315168167-10654-2-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1315168167-10654-2-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 2/2] mipsnet: use trace framework
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

On 09/04/2011 10:29 PM, Hervé Poussineau wrote:
> +mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64

This breaks the build, though actually it is because of a bug in the parser.  It
should be written as

mipsnet_write(uint64_t addr, uint64_t val) "write addr=0x%" PRIx64 " val=0x%" PRIx64 ""

Paolo