From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3S7I-0002wj-NC for qemu-devel@nongnu.org; Tue, 13 Sep 2011 08:29:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3S7E-0006TE-Oo for qemu-devel@nongnu.org; Tue, 13 Sep 2011 08:29:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3S7E-0006Sl-FO for qemu-devel@nongnu.org; Tue, 13 Sep 2011 08:29:28 -0400 Message-ID: <4E6F4CA2.5010308@redhat.com> Date: Tue, 13 Sep 2011 15:29:22 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1314898613-2066-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] versatile: cleanups to remove use of sysbus_mmio_init_cb2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 09/12/2011 06:01 PM, Peter Maydell wrote: > Ping? Sorry; applied to memory/queue. > On 1 September 2011 18:36, Peter Maydell wrote: > > A couple of patches which do some cleanup work to versatile > > devices following the recent MemoryRegion conversion. These > > both remove uses of sysbus_mmio_init_cb2(), which strikes me > > as kind of ugly and worth avoiding. (After these two patches > > it will be used by only sh_pci.c and ppce500_pci.c...) > > > > Peter Maydell (2): > > hw/arm11mpcore: Clean up to avoid using sysbus_mmio_init_cb2 > > hw/versatile_pci: Expose multiple sysbus mmio regions > > > > hw/arm11mpcore.c | 13 +------------ > > hw/realview.c | 12 ++++++++++-- > > hw/versatile_pci.c | 42 ++++++++---------------------------------- > > hw/versatilepb.c | 12 ++++++++++-- > > 4 files changed, 29 insertions(+), 50 deletions(-) -- error compiling committee.c: too many arguments to function